Opened 7 years ago

Closed 7 years ago

#6541 task closed fixed (fixed)

Avoid making ISSHConnectionCreator public just yet

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch: branches/private-conn-creator-interface-6541
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

ISSHConnectionCreator was introduced along with twisted.conch.endpoints as a related API for creating the two endpoints defined by that module.

In the course of #6532 it has become apparent that the interface may not be sufficiently expressive to allow cancellation to be implemented.

To avoid needing to introduce a new interface or find some way to make a backwards compatible change to ISSHConnectionCreator, it should be made private before it gets included in a release - so that we are not committed to supporting it *and* so that #6532 does not block an upcoming release.

The goal should be to make it public again soon after #6532 is resolved (or as part of #6532 itself).

Change History (5)

comment:1 Changed 7 years ago by DefaultCC Plugin

Cc: z3p added

comment:2 Changed 7 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/private-conn-creator-interface-6541

(In [38608]) Branching to 'private-conn-creator-interface-6541'

comment:3 Changed 7 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

comment:4 Changed 7 years ago by Jonathan Jacobs

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks good to me.

comment:5 Changed 7 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [38628]) Merge private-conn-creator-interface-6541

Author: exarkun Reviewer: jonathanj Fixes: #6541

Change ISSHConnectionCreator to _ISSHConnectionCreator so as not to make it a part of the public interface of twisted.conch.endpoints, pending some changes we probably want to make to it (at least for cancellation - see #6532).

Note: See TracTickets for help on using tickets.