Opened 5 years ago
Closed 5 years ago
#6524 release blocker: regression closed fixed (fixed)
twisted.mail.smtp.ESMTPClient tries to STARTTLS multiple times
Reported by: | Jean-Paul Calderone | Owned by: | Jean-Paul Calderone |
---|---|---|---|
Priority: | highest | Milestone: | |
Component: | Keywords: | ||
Cc: | ashfall | Branch: |
branches/judicious-smtp-starttls-6524
branch-diff, diff-cov, branch-cov, buildbot |
Author: | exarkun |
Description
If ESMTPClient
is used to connect to an SMTP server that offers the STARTTLS
feature, it will try to use it. If the SMTP server still offers the STARTTLS
after the command has been used once to start TLS, ESMTPClient
will try to use it again. This is useless at best, and in practice probably always triggers an error from the server and prevents mail from being sent.
This is a regression introduced by #3989.
Attachments (1)
Change History (9)
comment:1 Changed 5 years ago by
comment:2 Changed 5 years ago by
Cc: | ashfall added |
---|
comment:3 Changed 5 years ago by
Owner: | set to Jean-Paul Calderone |
---|---|
Status: | new → assigned |
comment:4 Changed 5 years ago by
Author: | → exarkun |
---|---|
Branch: | → branches/judicious-smtp-starttls-6524 |
(In [38818]) Branching to 'judicious-smtp-starttls-6524'
comment:5 Changed 5 years ago by
Keywords: | review added |
---|---|
Owner: | Jean-Paul Calderone deleted |
Status: | assigned → new |
Relatively straightforward; only wished I had schematic tables once during the entire development process (arguably the minimum number of times it is possible to wish for schematic tables when writing a piece of software).
comment:6 Changed 5 years ago by
Owner: | set to radix |
---|---|
Status: | new → assigned |
comment:7 Changed 5 years ago by
Keywords: | review removed |
---|---|
Owner: | changed from radix to Jean-Paul Calderone |
Status: | assigned → new |
Schematic tables would be nice. Maybe we should sprint on them some time.
[1] You have a "verify that" in a docstring in a test module, but I guess that's ok because it's not a test_ method itself, just a utility assertion method?
No flakes, tests pass, +1, please merge.
comment:8 Changed 5 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Here's a transcript demonstrating the consequences of this bug:
And attached is a script that reproduces it.