Opened 3 years ago

Last modified 3 years ago

#6515 defect new

twisted.python.reflect.objgrep test coverage is incomplete

Reported by: rwall Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:
Author: Launchpad Bug:


In #6362 Thijs noted that objgrep(showUnknown) is not covered by any tests.

There are also various objgrep convenience functions which are untested eg modgrep

As it stands, it's difficult to trigger the showUnknowns branch - you'd need to find some object type that is not already handled.

I thought about adding a special type which would never be recognised and which could be passed in for testing purposes.

Change History (2)

comment:1 Changed 3 years ago by therve

objgrep and modgrep are good candidates for deprecation I believe.

comment:2 Changed 3 years ago by exarkun

objgrep is awfully handy for certain kinds of debugging. modgrep is maybe an unnecessary helper, but it's hardly a lot of code. If these aren't in Twisted, then I'll have to find some other way to keep them around to use them, that'll probably be annoying.

Note: See TracTickets for help on using tickets.