Opened 8 years ago

Closed 8 years ago

#6498 defect closed fixed (fixed)

Unnecessary local variable `dn` in twisted.internet._sslverify.KeyPair.signRequestObject

Reported by: Jean-Paul Calderone Owned by: therve
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Branch:
Author:

Description

The line:

   dn = requestObject.getSubject()

is not necessary. The method call has no important side-effects and the local variable is not by any following code.

Attachments (1)

ticket6498.patch (638 bytes) - added by Can Ibanoglu 8 years ago.
removed the unused line, added a .misc topfile

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by Can Ibanoglu

Owner: set to Can Ibanoglu

Just one question before I submit a patch for this, should this one be deleted right away or should it be deprecated and then deleted at a later point in time? I believe it's the former but it's always nice to be sure

comment:2 Changed 8 years ago by Jean-Paul Calderone

Just one question before I submit a patch for this, should this one be deleted right away or should it be deprecated and then deleted at a later point in time? I believe it's the former but it's always nice to be sure

Yes, this can just be deleted. There's no need for a deprecation because no public part of the interface (either the signature of a method, the allowed argument values for any of the parameters, or some sufficiently important aspect of the implemented behavior) is being changed. Only an internal implementation detail is changing.

Thanks!

Changed 8 years ago by Can Ibanoglu

Attachment: ticket6498.patch added

removed the unused line, added a .misc topfile

comment:3 Changed 8 years ago by Can Ibanoglu

Keywords: review added
Owner: Can Ibanoglu deleted

comment:4 Changed 8 years ago by therve

Keywords: review removed
Owner: set to therve

Looks good, applying.

comment:5 Changed 8 years ago by therve

Resolution: fixed
Status: newclosed

(In [38578]) Remove a unused variable in sslverify KeyPair.signRequestObject method.

Author: canibanoglu Reviewer: therve Fixes: #6498

Note: See TracTickets for help on using tickets.