Opened 5 years ago

Last modified 4 years ago

#6491 defect new

test_pollingfile: producer data wrongly dropped when loseConnection() requested

Reported by: John Popplewell Owned by: John Popplewell
Priority: normal Milestone:
Component: core Keywords: windows
Cc: Branch:
Author:

Description

Attached is a patch to test_pollingfile.py which demonstrates the bug. See #5413 for the original report.

I have an abstract.FileDescriptor based fix to _pollingfile.py which resolves this and 5 other related bugs.

Attachments (2)

test_pollingfile-5413-data-dropped.patch (7.7 KB) - added by John Popplewell 5 years ago.
data-dropped-at-loseconnection-#6491.patch (5.4 KB) - added by John Popplewell 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by John Popplewell

comment:1 Changed 5 years ago by John Popplewell

Keywords: review removed

comment:2 Changed 5 years ago by John Popplewell

Keywords: windows review added
Owner: John Popplewell deleted

Now honors already produced data when loseConnection (close() with the current implementation) is called. Includes test.

Requires that the following tickets have been resolved: #2835, #2839, #5365, #6492 and #6493

Changed 5 years ago by John Popplewell

comment:3 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: set to John Popplewell

See #5365. Also,

  1. You test the changes to write but not writeSequence
  2. You don't test that the connection is closed after the producer is complete.
Note: See TracTickets for help on using tickets.