Opened 9 years ago
Closed 9 years ago
#6444 defect closed fixed (fixed)
Incorrect docstrings in test_usage.py
Reported by: | Stephen Solis | Owned by: | Stephen Solis |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | core | Keywords: | |
Cc: | Branch: | ||
Author: |
Description (last modified by )
Docstrings in twisted/test/test_usage.py
for ParseCorrectnessTest
, TypedTestCase
, and WrongTypedTestCase
indicate that Options.parseArgs
is being tested, but really Options.parseOptions
is being tested.
Attachments (4)
Change History (10)
Changed 9 years ago by
Attachment: | ticket6444_v1.diff added |
---|
comment:1 Changed 9 years ago by
Keywords: | review added |
---|---|
Owner: | Stephen Solis deleted |
Changed 9 years ago by
Attachment: | ticket6444_v1.patch added |
---|
comment:2 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Summary: | Incorrect comments in test_usage.py → Incorrect docstrings in test_usage.py |
comment:3 Changed 9 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Stephen Solis |
Thanks stephsolis. Well spotted.
- Your patch has trailing whitespace
- Missing news file
- Why don't you also add some of the missing docstrings eg to SubcommandTestCase and HelpStringTest etc
Please answer or address the points above and submit another patch for review.
comment:4 Changed 9 years ago by
Keywords: | review added |
---|---|
Owner: | Stephen Solis deleted |
comment:5 Changed 9 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Stephen Solis |
Thanks stephsolis.
The latest patch looks fine.
But I think on second thoughts I'll change the news file to a .misc - changes to test docstrings don't really need to show up in the next release notes.
Then I'll apply it to trunk.
-RichardW.
comment:6 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
change extension to .patch (d'oh!)