Opened 5 years ago

Closed 5 years ago

#6405 defect closed fixed (fixed)

os.geteuid and os.getegid are called unnecessarily in SSHPublicKeyDatabase.checkKey

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch: branches/effectively-pointless-6405
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

These functions are called and their results saved, but nothing is ever done with them.

Change History (5)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: z3p added

comment:2 Changed 5 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/effectively-pointless-6405

(In [37926]) Branching to 'effectively-pointless-6405'

comment:3 Changed 5 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

Just some deletions. Unfortunately some tests were affected. Build results.

comment:4 Changed 5 years ago by Tom Prince

Keywords: review removed
Owner: set to Jean-Paul Calderone

This looks good. Please merge.

comment:5 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [37949]) Merge effectively-pointless-6405

Author: exarkun Reviewer: tom.prince Fixes: #6405

Remove some unnecessary code from the implementation of SSHPublicKeyDatabase.checkKey.

Note: See TracTickets for help on using tickets.