Opened 5 years ago

Closed 5 years ago

#6402 defect closed fixed (fixed)

twisted.words setup metadata is not up to date anymore

Reported by: Thijs Triemstra Owned by: nothung
Priority: normal Milestone:
Component: words Keywords: documentation easy gsoc
Cc: Thijs Triemstra, ralphm Branch: branches/words-setup-metadata-6402
branch-diff, diff-cov, branch-cov, buildbot
Author: rwall

Description

[source:trunk/twisted/words/topfiles/setup.py]'s long_description and classifiers talk about MSN, OSCAR (AIM & ICQ), TOC (AOL), and X-Ish. All gone by now.

Attachments (2)

twisted-words-topfiles-setup.patch (598 bytes) - added by nothung 5 years ago.
patch to Ticket #6402, updates long_description in twisted/words/topfiles/setup.py
twisted-words-topfiles-setup-v2.patch (1002 bytes) - added by nothung 5 years ago.
(revised) patch to Ticket #6402, updates long_description in twisted/words/topfiles/setup.py , (new to this revision) text is reflowed to meet Twisted coding standards

Download all attachments as: .zip

Change History (15)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: ralphm added

comment:2 Changed 5 years ago by ralphm

OSCAR support is still there though, and the XMPP support in Words is built on top of xish.

comment:3 Changed 5 years ago by nothung

Owner: set to nothung
Status: newassigned

Changed 5 years ago by nothung

patch to Ticket #6402, updates long_description in twisted/words/topfiles/setup.py

comment:4 Changed 5 years ago by nothung

Keywords: review added

The above patch removes mentions of "MSN" and "TOC (AOL)" from long_description. Kept mentions of "OSCAR (AIM & ICQ)" and "X-ish" following ralphm's suggestion.

Please review this patch for the Outreach Program for Woman (OPW). Thanks!

comment:5 Changed 5 years ago by jesstess

Owner: nothung deleted
Status: assignednew

comment:6 Changed 5 years ago by Tom Prince

Keywords: gsoc added; review removed
Owner: set to nothung

This looks good, but the description probably wants to be reflowed.

Changed 5 years ago by nothung

(revised) patch to Ticket #6402, updates long_description in twisted/words/topfiles/setup.py , (new to this revision) text is reflowed to meet Twisted coding standards

comment:7 Changed 5 years ago by nothung

Keywords: review added

comment:8 Changed 5 years ago by nothung

Owner: nothung deleted

comment:9 Changed 5 years ago by Richard Wall

Owner: set to Richard Wall
Status: newassigned

reviewing...

comment:10 Changed 5 years ago by Richard Wall

Author: rwall
Branch: branches/words-setup-metadata-6402

(In [38194]) Branching to 'words-setup-metadata-6402'

comment:11 Changed 5 years ago by Richard Wall

(In [38195]) apply twisted-words-topfiles-setup-v2.patch refs #6402

comment:12 Changed 5 years ago by Richard Wall

Keywords: review removed
Owner: changed from Richard Wall to nothung
Status: assignednew

Code Review:

Thanks nothung for rewrapping and submitting a second patch.

I've added it to a branch and fixed a couple of things:

  • log:branches/words-setup-metadata-6402
  1. There was some trailing whitespace in the patch which I have removed. Try setting up your editor to remove trailing whitespace.

See https://twistedmatrix.com/documents/current/core/development/policy/coding-standard.html#auto5

  1. I added an empty .misc news file - always include a news file in your patches. Although empty files can be difficult with svn diff.

See https://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles

Otherwise this looks fine and I'll merge it to trunk.

-RichardW.

comment:13 Changed 5 years ago by Richard Wall

Resolution: fixed
Status: newclosed

(In [38198]) Merge words-setup-metadata-6402

Author: nothung Reviewer: tomprince,rwall Fixes: #6402

Remove mention of obsolete protocols from the twisted.words setup.py metadata.

Note: See TracTickets for help on using tickets.