twisted.web.test.requesthelper.DummyChannel.TCP does not have the unregisterProducer method.

[moijes12]

twisted.web.test.requesthelper.DummyChannel.TCP is written for helping in testing of http.Request. It does have a counterpart to the twisted.web.http.Request.registerProducer but not the unregisterProducer. This unregisterProducer needs to be implemented.

[Jean-Paul Calderone]

Rather than expanding this test double, it might be better to consolidate and make the Twisted Web tests work with twisted.test.proto_helpers.StringTransport instead.

[Kai Zhang]

Now twisted.web.test.requesthelper.DummyChannel.TCP is inherit from twisted.test.proto_helpers.StringTransport. Tests in twisted.web.test are revised accordingly.

[Kai Zhang]

Now twisted.web.test.requesthelper.DummyChannel.TCP is inherit from twisted.test.proto_helpers.StringTransport. The reason why not use twisted.test.proto_helpers.StringTransport directly is that twisted.web.test.requesthelper.DummyChannel.TCP can set port and return host accordingly.

Now twisted.web.test.requesthelper.DummyChannel.TCP is like this:

class DummyChannel:
     class TCP(StringTransport):
         port = 80
 
         def getHost(self):
             return IPv4Address("TCP", '10.0.0.1', self.port)
     ...

Then I revised the tests in twisted.web.test accordingly.

[Jean-Paul Calderone]

Thanks.

The reason why not use twisted.test.proto_helpers.StringTransport directly is that twisted.web.test.requesthelper.DummyChannel.TCP can set port and return host accordingly

Actually, StringTransport supports this: you can pass the hostAddress keyword argument to its initializer to specify any return value for getHost that you like.

[Kai Zhang]

Now twisted.web.test.requesthelper.DummyChannel.TCP is inherit from twisted.test.proto_helpers.StringTransport. Tests in twisted.web.test are revised accordingly.

[Kai Zhang]

Replying to exarkun:

Thanks.

The reason why not use twisted.test.proto_helpers.StringTransport directly is that twisted.web.test.requesthelper.DummyChannel.TCP can set port and return host accordingly

Actually, StringTransport supports this: you can pass the hostAddress keyword argument to its initializer to specify any return value for getHost that you like.

Hi, now twisted.web.test.requesthelper.DummyChannel.TCP is just twisted.test.proto_helpers.StringTransport.

[Tom Prince]

(In [38791]) Branching to replace-DummyChannel.TCP-with-StringTransport-6401.

[Tom Prince]

(In [38792]) Apply 6401.1.patch from kkpattern.

Refs: #6401

[Tom Prince]

1. Is there a reason for TCP and SSL to be seperate classes, rather than just using StringTransport directly?
   • I did some experiments, and it appears that TCP can entirely be replaced
   • The code does depend on SSL implementing ISSLTransport (although SSL doesn't have all the required methods).

• So, I think that TCP should just be removed entirely, and SSL can stay as-is, for the moment.

2. Rather than setting hostAddr directly, you should pass the address to the constructor, instead.

Please resubmit for review after addressing the above two points.