Opened 5 years ago

Closed 5 years ago

#6381 defect closed fixed (fixed)

There are some duplicate implementations of (Clock, MemoryReactor) combiner

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/clockmemoryreactor-6381
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

We have a bunch of subclasses of Clock and MemoryReactor in various places. We should remove the duplication.

Change History (5)

comment:1 Changed 5 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/clockmemoryreactor-6381

(In [37659]) Branching to 'clockmemoryreactor-6381'

comment:2 Changed 5 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

Pretty simple. Here are the build results. pyflakes results seem a bit nonsensical, not sure what's going on there.

comment:3 Changed 5 years ago by Jean-Paul Calderone

And by pyflakes I meant twistedchecker, I guess.

comment:4 Changed 5 years ago by therve

Keywords: review removed
Owner: set to Jean-Paul Calderone

Wonderful, please merge.

comment:5 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [37671]) Merge clockmemoryreactor-6381

Author: exarkun Reviewer: therve Fixes: #6381

Eliminate the various duplicate versions of a Clock / MemoryReactor subclass used in a number of different tests.

Note: See TracTickets for help on using tickets.