Opened 5 years ago
Closed 5 years ago
#6354 defect closed fixed (fixed)
Main NEWS file is not generated properly anymore
| Reported by: | therve | Owned by: | therve |
|---|---|---|---|
| Priority: | high | Milestone: | Twisted-13.0.0 |
| Component: | release management | Keywords: | |
| Cc: | radix | Branch: |
branches/proper-news-delete-6354
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | therve |
Description
In #4315, we introduced automatic removal of NEWS fragments. Unfortunately, that means that the subprojects NEWS files are built properly, but not the main one, as the fragments are deleted when it tries to build it. I'll attempt to fix it if it's easy, otherwise revert the commit if I can't.
Change History (8)
comment:1 Changed 5 years ago by
| Cc: | radix added |
|---|
comment:2 Changed 5 years ago by
| Author: | → therve |
|---|---|
| Branch: | → branches/proper-news-delete-6354 |
comment:3 Changed 5 years ago by
| Keywords: | review added |
|---|---|
| Owner: | therve deleted |
It's ready for review, fairly easy fix. I'm sad we didn't have the test before...
comment:4 Changed 5 years ago by
comment:5 Changed 5 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to therve |
It feels like too much logic is being put in _iterprojects. It seems like it might make more sense for it to just yield topfiles, name, version and then buildAll can build both the project and aggregate NEWS and then delete the files.
Otherwise, in isolation, the changes look good.
comment:6 Changed 5 years ago by
| Keywords: | review added |
|---|---|
| Owner: | changed from therve to Tom Prince |
It sounds reasonable, changed in r37426.
comment:7 Changed 5 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | changed from Tom Prince to therve |
- Add a note to _deleteFragments that it needs to be called from an svn repo.
- Calculate
once.
"Twisted %s %s (%s)" % (name, version.base(), today)
Please merge after making the above changes.
comment:8 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [37421]) Branching to 'proper-news-delete-6354'