Opened 4 years ago

Closed 4 years ago

#6354 defect closed fixed (fixed)

Main NEWS file is not generated properly anymore

Reported by: therve Owned by: therve
Priority: high Milestone: Twisted-13.0.0
Component: release management Keywords:
Cc: radix Branch: branches/proper-news-delete-6354
branch-diff, diff-cov, branch-cov, buildbot
Author: therve

Description

In #4315, we introduced automatic removal of NEWS fragments. Unfortunately, that means that the subprojects NEWS files are built properly, but not the main one, as the fragments are deleted when it tries to build it. I'll attempt to fix it if it's easy, otherwise revert the commit if I can't.

Change History (8)

comment:1 Changed 4 years ago by DefaultCC Plugin

Cc: radix added

comment:2 Changed 4 years ago by therve

Author: therve
Branch: branches/proper-news-delete-6354

(In [37421]) Branching to 'proper-news-delete-6354'

comment:3 Changed 4 years ago by therve

Keywords: review added
Owner: therve deleted

It's ready for review, fairly easy fix. I'm sad we didn't have the test before...

comment:5 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: set to therve

It feels like too much logic is being put in _iterprojects. It seems like it might make more sense for it to just yield topfiles, name, version and then buildAll can build both the project and aggregate NEWS and then delete the files.

Otherwise, in isolation, the changes look good.

comment:6 Changed 4 years ago by therve

Keywords: review added
Owner: changed from therve to Tom Prince

It sounds reasonable, changed in r37426.

comment:7 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: changed from Tom Prince to therve
  1. Add a note to _deleteFragments that it needs to be called from an svn repo.
  2. Calculate
    "Twisted %s %s (%s)" % (name, version.base(), today)
    
    once.

Please merge after making the above changes.

comment:8 Changed 4 years ago by therve

Resolution: fixed
Status: newclosed

(In [37437]) Merge proper-news-delete-6354

Author: therve Reviewer: tom.prince Fixes: #6354

Only delete NEWS fragment once all NEWS file are built, to prevent issues when creating the main NEWS aggregating the others.

Note: See TracTickets for help on using tickets.