Opened 6 years ago
Closed 6 years ago
#6349 defect closed fixed (fixed)
MemoryReactor incompletely implements IReactorSocket
| Reported by: | Jean-Paul Calderone | Owned by: | Jean-Paul Calderone |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | core | Keywords: | |
| Cc: | Branch: |
branches/memoryreactor-adoptconn-6349
branch-diff, diff-cov, branch-cov, buildbot |
|
| Author: | exarkun |
Description
It has no adoptStreamConnection method.
Change History (5)
comment:1 Changed 6 years ago by
| Author: | → exarkun |
|---|---|
| Branch: | → branches/memoryreactor-adoptconn-6349 |
comment:2 Changed 6 years ago by
| Keywords: | review added |
|---|---|
| Owner: | Jean-Paul Calderone deleted |
comment:3 Changed 6 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Jean-Paul Calderone |
Looks good. I'd consider creating a test module for proto_helpers and putting the verification in a test case there. (This is perhaps overkill for this test, but I think we want a verified test reactor, at some point, so creating a module to put tests in would be a good start).
Please merge, after optionally creating the test module.
comment:4 Changed 6 years ago by
Thanks. I agree some testing would be better, but I don't want to work on that at the moment. proto_helpers isn't the ultimate location for any solid testing tools anyway, since the right location will not be inside a test package.
comment:5 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
(In [37374]) Branching to 'memoryreactor-adoptconn-6349'