Opened 3 years ago

Last modified 3 years ago

#6335 enhancement new

utf-8 telnet terminal input support for conch required

Reported by: nnseva Owned by:
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch:
Author:

Description

The conch manhole telnet terminal server doesn't support utf-8 input at all and blocks it.

Support for utf-8 (and probably other encoding) input/output is required.

The code inheriting and overwriting twisted conch classes to make utf-8 and other encodings available is applied. It was successfully tested on Linux and Windows telnet clients.

Attachments (1)

manhole.py (9.8 KB) - added by nnseva 3 years ago.
The code inheriting and overriding existent conch manhole classes to provide requested functionality

Download all attachments as: .zip

Change History (4)

comment:1 Changed 3 years ago by DefaultCC Plugin

  • Cc z3p added

Changed 3 years ago by nnseva

The code inheriting and overriding existent conch manhole classes to provide requested functionality

comment:2 Changed 3 years ago by exarkun

Thanks for your work on this issue. Proper support for non-ASCII input (and, probably, output) in twisted.conch.insults would be wonderful. Someone even obscurely requested this feature many years ago (#1756) but without much detail and with no follow up.

Please take a look at TwistedDevelopment and ReviewProcess. A couple things I'll highlight:

  • Add the "review" keyword to a ticket when you want someone to consider applying a change. There are thousands of open tickets and it's very easy for yours to get lost in the pile without this step.
  • Contribute changes as patches rather than .py files
  • All code must have full automated unit test coverage

comment:3 Changed 3 years ago by nnseva

Yes, I would probably make the full-functional patch. The code applied before is for those people who wanted to have the workaround before the patch is applied to the current version.

Note: See TracTickets for help on using tickets.