Opened 3 years ago

Closed 3 years ago

#6333 enhancement closed fixed (fixed)

Deprecate DryRunVisitor.

Reported by: tom.prince Owned by: tom.prince
Priority: normal Milestone:
Component: trial Keywords: easy
Cc: jml Branch: branches/deprecate-dryrunvisitor-6333-2
(github, patch, buildbot, log)
Author: tomprince Launchpad Bug:

Description

It is no longer used (#4063) and the support for visitors is being removed (#3231), so there is no reason to keep this around.

Change History (8)

comment:1 Changed 3 years ago by DefaultCC Plugin

  • Cc jml added

comment:2 Changed 3 years ago by tomprince

  • Author set to tomprince
  • Branch set to branches/deprecate-dryrunvisitor-6333

(In [37274]) Branching to deprecate-dryrunvisitor-6333.

comment:3 Changed 3 years ago by tom.prince

  • Keywords review added

This should probably land after #3231.

comment:4 Changed 3 years ago by tom.prince

comment:5 Changed 3 years ago by glyph

  • Keywords review removed
  • Owner set to tom.prince

This looks fine to me, such as it is, but, as with many deprecations in Twisted, I feel like the explanation is not really sufficient. Why are visitors no longer supported? If I had written some code (what code might I have written?) that was using this class, what do I need to do instead of using visitors? If you can think of more useful words to add to the deprecation message explaining why this was done, please do so.

comment:6 Changed 3 years ago by exarkun

This looks fine to me, such as it is, but, as with many deprecations in Twisted, I feel like the explanation is not really sufficient.

I agree.

Why are visitors no longer supported? If I had written some code (what code might I have written?) that was using this class, what do I need to do instead of using visitors? If you can think of more useful words to add to the deprecation message explaining why this was done, please do so.

Visitors were deprecated in #2897, to be replaced by test decorators. I think jml or lifeless should be herded into a closet until they write up some documentation about test decorators.

comment:7 Changed 3 years ago by tomprince

  • Branch changed from branches/deprecate-dryrunvisitor-6333 to branches/deprecate-dryrunvisitor-6333-2

(In [37586]) Branching to deprecate-dryrunvisitor-6333-2.

comment:8 Changed 3 years ago by tomprince

  • Resolution set to fixed
  • Status changed from new to closed

(In [37587]) Merge deprecate-dryrunvisitor-6333-2: Deprecate DryRunVisitor.

Author: tom.prince Reviewers: glyph Fixes: #6333

It is no longer used (#4063) and the support for visitors is being removed (#3231), so there is no reason to keep this around.

Note: See TracTickets for help on using tickets.