Opened 5 years ago
Closed 5 years ago
#6333 enhancement closed fixed (fixed)
Deprecate DryRunVisitor.
| Reported by: | Tom Prince | Owned by: | Tom Prince |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | trial | Keywords: | easy |
| Cc: | Jonathan Lange | Branch: |
branches/deprecate-dryrunvisitor-6333-2
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | tomprince |
Change History (8)
comment:1 Changed 5 years ago by
| Cc: | Jonathan Lange added |
|---|
comment:2 Changed 5 years ago by
| Author: | → tomprince |
|---|---|
| Branch: | → branches/deprecate-dryrunvisitor-6333 |
comment:5 Changed 5 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Tom Prince |
This looks fine to me, such as it is, but, as with many deprecations in Twisted, I feel like the explanation is not really sufficient. Why are visitors no longer supported? If I had written some code (what code might I have written?) that was using this class, what do I need to do instead of using visitors? If you can think of more useful words to add to the deprecation message explaining why this was done, please do so.
comment:6 Changed 5 years ago by
This looks fine to me, such as it is, but, as with many deprecations in Twisted, I feel like the explanation is not really sufficient.
I agree.
Why are visitors no longer supported? If I had written some code (what code might I have written?) that was using this class, what do I need to do instead of using visitors? If you can think of more useful words to add to the deprecation message explaining why this was done, please do so.
Visitors were deprecated in #2897, to be replaced by test decorators. I think jml or lifeless should be herded into a closet until they write up some documentation about test decorators.
comment:7 Changed 5 years ago by
| Branch: | branches/deprecate-dryrunvisitor-6333 → branches/deprecate-dryrunvisitor-6333-2 |
|---|
(In [37586]) Branching to deprecate-dryrunvisitor-6333-2.
comment:8 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [37274]) Branching to deprecate-dryrunvisitor-6333.