Opened 5 years ago

Closed 5 years ago

#6326 defect closed fixed (fixed)

web/test_template emits DeprecationWarning

Reported by: Tom Prince Owned by: Tom Prince
Priority: normal Milestone:
Component: web Keywords: easy
Cc: jknight Branch: branches/web.test_template-emits-DeprecationWarning-6326
branch-diff, diff-cov, branch-cov, buildbot
Author: tomprince

Description


Change History (13)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 5 years ago by Tom Prince

Author: tomprince
Branch: branches/web.test_template-emits-DeprecationWarning-6326

(In [37225]) Branching to web.test_template-emits-DeprecationWarning-6326.

comment:3 Changed 5 years ago by Tom Prince

Keywords: easy review added

comment:4 Changed 5 years ago by Richard Wall

comment:5 Changed 5 years ago by Richard Wall

Keywords: review removed
Owner: set to Tom Prince

Code Review:

+1 from me. Please merge.

comment:6 Changed 5 years ago by Tom Prince

Resolution: fixed
Status: newclosed

(In [37372]) Merge web.test_template-emits-DeprecationWarning-6326: Filter expected DeprecationWarnings from twisted.web.test.test_template.

Author: tom.prince Reviewers: rwall Fixes: #6326

Passing filenames or files to twisted.web.template.XMLFile is deprecated but need to be tested. Mask the deprecation warnings until support can be removed.

comment:7 Changed 5 years ago by Thijs Triemstra

Minor thingy, make sure the news file is in the correct topfiles folder (should've been web in this case).

comment:8 Changed 5 years ago by Richard Wall

Ah. Sorry I didn't spot that. Sorry. And I was just complaining on IRC that these changes were too small to be worth reviewing individually.

comment:9 Changed 5 years ago by Tom Prince

Resolution: fixed
Status: closedreopened

(In [37381]) Revert r37372: Filter expected DeprecationWarnings from twisted.web.test.test_template.

topfile in the wrong place

Reopens: #6326

comment:10 Changed 5 years ago by Tom Prince

(In [37382]) Put the topfile in the right place.

Refs #6326.

comment:11 Changed 5 years ago by Tom Prince

Keywords: review added
Owner: Tom Prince deleted
Status: reopenednew

comment:12 Changed 5 years ago by Thijs Triemstra

Keywords: review removed
Owner: set to Tom Prince

Thanks for going through all that trouble tom, please merge.

comment:13 Changed 5 years ago by Tom Prince

Resolution: fixed
Status: newclosed

(In [37393]) Merge web.test_template-emits-DeprecationWarning-6326: Filter expected DeprecationWarnings from twisted.web.test.test_template.

Author: tom.prince Reviewers: rwall, thijs Fixes: #6326

Passing filenames or files to twisted.web.template.XMLFile is deprecated but need to be tested. Mask the deprecation warnings until support can be removed.

Note: See TracTickets for help on using tickets.