Opened 8 years ago
Closed 8 years ago
#6326 defect closed fixed (fixed)
web/test_template emits DeprecationWarning
| Reported by: | Tom Prince | Owned by: | Tom Prince |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | web | Keywords: | easy |
| Cc: | jknight | Branch: |
branches/web.test_template-emits-DeprecationWarning-6326
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | tomprince |
Description
Change History (13)
comment:1 Changed 8 years ago by
| Cc: | jknight added |
|---|
comment:2 Changed 8 years ago by
| Author: | → tomprince |
|---|---|
| Branch: | → branches/web.test_template-emits-DeprecationWarning-6326 |
comment:3 Changed 8 years ago by
| Keywords: | easy review added |
|---|
comment:5 Changed 8 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Tom Prince |
Code Review:
- Changes look fine.
- Build looks fine. (in fact better than I've ever seen it!)
- XMLFile file and path deprecation warnings have disappeared from the python 2.6 build results.
+1 from me. Please merge.
comment:6 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [37372]) Merge web.test_template-emits-DeprecationWarning-6326: Filter expected DeprecationWarnings from twisted.web.test.test_template.
Author: tom.prince Reviewers: rwall Fixes: #6326
Passing filenames or files to twisted.web.template.XMLFile is deprecated but need to be tested. Mask the deprecation warnings until support can be removed.
comment:7 Changed 8 years ago by
Minor thingy, make sure the news file is in the correct topfiles folder (should've been web in this case).
comment:8 Changed 8 years ago by
Ah. Sorry I didn't spot that. Sorry. And I was just complaining on IRC that these changes were too small to be worth reviewing individually.
comment:9 Changed 8 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:11 Changed 8 years ago by
| Keywords: | review added |
|---|---|
| Owner: | Tom Prince deleted |
| Status: | reopened → new |
comment:12 Changed 8 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Tom Prince |
Thanks for going through all that trouble tom, please merge.
comment:13 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [37393]) Merge web.test_template-emits-DeprecationWarning-6326: Filter expected DeprecationWarnings from twisted.web.test.test_template.
Author: tom.prince Reviewers: rwall, thijs Fixes: #6326
Passing filenames or files to twisted.web.template.XMLFile is deprecated but need to be tested. Mask the deprecation warnings until support can be removed.
(In [37225]) Branching to web.test_template-emits-DeprecationWarning-6326.