Opened 4 years ago

Closed 4 years ago

#6324 defect closed fixed (fixed)

twisted/python/test/test_util.py emits DeprecationWarning

Reported by: Tom Prince Owned by: Tom Prince
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Branch: branches/python.test_util-emits-DeprecationWarning-6324
branch-diff, diff-cov, branch-cov, buildbot
Author: tomprince

Description


Change History (5)

comment:1 Changed 4 years ago by Tom Prince

Author: tomprince
Branch: branches/python.test_util-emits-DeprecationWarning-6324

(In [37223]) Branching to python.test_util-emits-DeprecationWarning-6324.

comment:2 Changed 4 years ago by Tom Prince

Keywords: easy review added

comment:3 Changed 4 years ago by Richard Wall

comment:4 Changed 4 years ago by Richard Wall

Keywords: review removed
Owner: set to Tom Prince

Code Review:

Looks good.

  1. One new twistedchecker warning which may as well be fixed
    ************* Module twisted.python.test.test_util
    W9013:1045,0: Expected 3 blank lines, found 4
    

+1 Fix the twistedchecker warning and merge.

comment:5 Changed 4 years ago by Tom Prince

Resolution: fixed
Status: newclosed

(In [37373]) Merge python.test_util-emits-DeprecationWarning-6324: Filter expected DeprecationWarnings from twisted.python.test.test_util.

Author: tom.prince Reviewers: rwall Fixes: #6324

twisted.python.util.getPluginDir is deprecated, but need to be tested. Mask the deprecation warnings until they can be removed.

Note: See TracTickets for help on using tickets.