Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#6321 task closed fixed (fixed)

Remove deprecated NetstringReceiver parser state attributes

Reported by: Thijs Triemstra Owned by: Thijs Triemstra
Priority: low Milestone:
Component: core Keywords: easy
Cc: Thijs Triemstra Branch: branches/parser-attr-6321
branch-diff, diff-cov, branch-cov, buildbot
Author: vasuman

Description

LENGTH, DATA, COMMA, and NUMBER in [source:trunk/twisted/protocols/basic.py] are deprecated since 10.2 (#4541/r29962) and can be removed.

Attachments (2)

first-twisted-patch.patch (2.4 KB) - added by Vasuman R 6 years ago.
6321.patch (638 bytes) - added by eddie 6 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by Itamar Turner-Trauring

Keywords: easy added

comment:2 Changed 6 years ago by eddie

Owner: set to eddie
Status: newassigned

Changed 6 years ago by Vasuman R

Attachment: first-twisted-patch.patch added

comment:3 Changed 6 years ago by eddie

Owner: eddie deleted
Status: assignednew

Changed 6 years ago by eddie

Attachment: 6321.patch added

comment:4 Changed 6 years ago by eddie

only deleted "LENGTH, DATA, COMMA NUMBER" without modifying the corresponding test case as it's already deleted in ticket #6042

comment:5 in reply to:  4 Changed 6 years ago by Thijs Triemstra

Owner: set to eddie

Replying to introom:

only deleted "LENGTH, DATA, COMMA NUMBER" without modifying the corresponding test case as it's already deleted in ticket #6042

I think you forgot to add the review keyword for this ticket? You should keep this ticket focused on one task and I don't see why #6042 should have the corresponding test case deleted, and not this ticket. It would mean merging this patch results in a broken test since the test case is there but the code's gone. Can you supply a new patch and keep everything related to this ticket here and not partly in #6042? Thanks!

comment:6 Changed 6 years ago by Thijs Triemstra

Owner: changed from eddie to Thijs Triemstra
Status: newassigned

I now see vasuman also added a patch 2 days ago (first-twisted-patch.patch) which does everything we want. Not sure why introom added a new patch, but vasuman should've simply unassigned him or herself from the ticket and add the 'review' keyword.

I'll put that patch in a branch and run it on the buildslaves.

comment:7 Changed 6 years ago by Thijs Triemstra

Author: thijs
Branch: branches/parser-attr-6321

(In [38137]) Branching to 'parser-attr-6321'

comment:8 Changed 6 years ago by Thijs Triemstra

(In [38138]) apply first-twisted-patch.patch, add news file. refs #6321

comment:9 Changed 6 years ago by Thijs Triemstra

Author: thijsvasuman

Started a build, will merge when all's good.

comment:10 in reply to:  6 Changed 6 years ago by eddie

Replying to thijs:

I now see vasuman also added a patch 2 days ago (first-twisted-patch.patch) which does everything we want. Not sure why introom added a new patch, but vasuman should've simply unassigned him or herself from the ticket and add the 'review' keyword.

I'll put that patch in a branch and run it on the buildslaves.

because I was handling ticket #6042 which also modifies twisted.protocols.test.test_basic, so I modified it with consideration of this ticket. As this may cause some merging conflicts, so I planned to not add the review keyword (until 6042 is fixed).

comment:11 Changed 6 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [38148]) Merge parser-attr-6321: The NetstringReceiver parser state attributes in t.protocols.basic, deprecated since 10.2, are removed now.

Author: vasuman Reviewer: thijs Fixes: #6321

comment:12 Changed 6 years ago by Jean-Paul Calderone

Please follow the style guide at http://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles for news fragments. Thanks.

Note: See TracTickets for help on using tickets.