#6321 task closed fixed (fixed)
Remove deprecated NetstringReceiver parser state attributes
| Reported by: | Thijs Triemstra | Owned by: | Thijs Triemstra |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | core | Keywords: | easy |
| Cc: | Thijs Triemstra | Branch: |
branches/parser-attr-6321
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | vasuman |
Attachments (2)
Change History (14)
comment:1 Changed 7 years ago by
| Keywords: | easy added |
|---|
comment:2 Changed 7 years ago by
| Owner: | set to eddie |
|---|---|
| Status: | new → assigned |
Changed 7 years ago by
| Attachment: | first-twisted-patch.patch added |
|---|
comment:3 Changed 7 years ago by
| Owner: | eddie deleted |
|---|---|
| Status: | assigned → new |
Changed 7 years ago by
| Attachment: | 6321.patch added |
|---|
comment:4 follow-up: 5 Changed 7 years ago by
comment:5 Changed 7 years ago by
| Owner: | set to eddie |
|---|
Replying to introom:
only deleted "LENGTH, DATA, COMMA NUMBER" without modifying the corresponding test case as it's already deleted in ticket #6042
I think you forgot to add the review keyword for this ticket? You should keep this ticket focused on one task and I don't see why #6042 should have the corresponding test case deleted, and not this ticket. It would mean merging this patch results in a broken test since the test case is there but the code's gone. Can you supply a new patch and keep everything related to this ticket here and not partly in #6042? Thanks!
comment:6 follow-up: 10 Changed 7 years ago by
| Owner: | changed from eddie to Thijs Triemstra |
|---|---|
| Status: | new → assigned |
I now see vasuman also added a patch 2 days ago (first-twisted-patch.patch) which does everything we want. Not sure why introom added a new patch, but vasuman should've simply unassigned him or herself from the ticket and add the 'review' keyword.
I'll put that patch in a branch and run it on the buildslaves.
comment:7 Changed 7 years ago by
| Author: | → thijs |
|---|---|
| Branch: | → branches/parser-attr-6321 |
(In [38137]) Branching to 'parser-attr-6321'
comment:8 Changed 7 years ago by
comment:9 Changed 7 years ago by
| Author: | thijs → vasuman |
|---|
Started a build, will merge when all's good.
comment:10 Changed 7 years ago by
Replying to thijs:
I now see vasuman also added a patch 2 days ago (first-twisted-patch.patch) which does everything we want. Not sure why introom added a new patch, but vasuman should've simply unassigned him or herself from the ticket and add the 'review' keyword.
I'll put that patch in a branch and run it on the buildslaves.
because I was handling ticket #6042 which also modifies twisted.protocols.test.test_basic, so I modified it with consideration of this ticket. As this may cause some merging conflicts, so I planned to not add the review keyword (until 6042 is fixed).
comment:11 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:12 Changed 7 years ago by
Please follow the style guide at http://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles for news fragments. Thanks.
only deleted "LENGTH, DATA, COMMA NUMBER" without modifying the corresponding test case as it's already deleted in ticket #6042