LookupsTestCase.test_importExceptions failing on python 3.3

[Thijs Triemstra]

test_importExceptions is failing on Python 3.3 only because a statement was modified to clean up Python 2.3 code which introduced an issue in test_reflectpy3.LookupsTestCase. This wasn't caught initially because the buildslave for python 3.3 is down (at the time of this writing).

======================================================================
FAIL: test_importExceptions (twisted.python.test.test_reflectpy3.LookupsTestCase)
test_importExceptions
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/trial/_synctest.py", line 328, in assertRaises
    result = f(*args, **kwargs)
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/python/_reflectpy3.py", line 273, in namedAny
    obj = getattr(obj, n)
AttributeError: 'module' object has no attribute 'reflect_helper_IE'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/trial/_synctest.py", line 1185, in _run
    runWithWarningsSuppressed(suppress, method)
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/python/util.py", line 1065, in runWithWarningsSuppressed
    return f(*args, **kwargs)
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/python/test/test_reflectpy3.py", line 290, in test_importExceptions
    reflect.namedAny, "twisted.test.reflect_helper_IE")
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/trial/_synctest.py", line 335, in assertRaises
    failure.Failure().getTraceback()))
twisted.trial.unittest.FailTest: <class 'AttributeError'> raised instead of ImportError:
 Traceback (most recent call last):
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/trial/_synctest.py", line 1216, in _runFixturesAndTest
    if self._run(suppress, todo, method, result):
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/trial/_synctest.py", line 1185, in _run
    runWithWarningsSuppressed(suppress, method)
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/python/util.py", line 1065, in runWithWarningsSuppressed
    return f(*args, **kwargs)
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/python/test/test_reflectpy3.py", line 290, in test_importExceptions
    reflect.namedAny, "twisted.test.reflect_helper_IE")
--- <exception caught here> ---
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/trial/_synctest.py", line 328, in assertRaises
    result = f(*args, **kwargs)
  File "/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/python/_reflectpy3.py", line 273, in namedAny
    obj = getattr(obj, n)
builtins.AttributeError: 'module' object has no attribute 'reflect_helper_IE'

[Tom Prince]

This should perhaps have some sort of comment.

[Thijs Triemstra]

Let me put that in a branch actually so it can be tested (when the 3.3 buildslave is back up).

[Thijs Triemstra]

(In [37125]) Branching to 'import-checkstack-6298'

[Thijs Triemstra]

(In [37126]) add note about execName, add news file. refs #6298

[Thijs Triemstra]

Forced a ​build. Up for review.

[Tom Prince]

(In [37129]) Revert r37124: LookupsTestCase.test_importExceptions failing on python 3.3

test_importExceptions is failing on Python 3.3 only because a statement was modified to clean up Python 2.3 code which introduced an issue in test_reflectpy3.LookupsTestCase. This wasn't caught initially because the buildslave for python 3.3 wass down.

====================================================================== FAIL: test_importExceptions (twisted.python.test.test_reflectpy3.LookupsTestCase) test_importExceptions

---

Traceback (most recent call last):

File "twisted/trial/_synctest.py", line 328, in assertRaises

result = f(*args, kwargs)

File "twisted/python/_reflectpy3.py", line 273, in namedAny

obj = getattr(obj, n)

AttributeError: 'module' object has no attribute 'reflect_helper_IE'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

File "twisted/trial/_synctest.py", line 1185, in _run

runWithWarningsSuppressed(suppress, method)

File "twisted/python/util.py", line 1065, in runWithWarningsSuppressed

return f(*args, kwargs)

File "twisted/python/test/test_reflectpy3.py", line 290, in test_importExceptions

reflect.namedAny, "twisted.test.reflect_helper_IE")

File "software/twisted/svn/Twisted/trunk/twisted/trial/_synctest.py", line 335, in assertRaises

failure.Failure().getTraceback()))

twisted.trial.unittest.FailTest: <class 'AttributeError'> raised instead of ImportError:

Traceback (most recent call last):

File "twisted/trial/_synctest.py", line 1216, in _runFixturesAndTest

if self._run(suppress, todo, method, result):

File "twisted/trial/_synctest.py", line 1185, in _run

runWithWarningsSuppressed(suppress, method)

File "twisted/python/util.py", line 1065, in runWithWarningsSuppressed

return f(*args, kwargs)

File "twisted/python/test/test_reflectpy3.py", line 290, in test_importExceptions

reflect.namedAny, "twisted.test.reflect_helper_IE")

--- <exception caught here> ---

File "twisted/trial/_synctest.py", line 328, in assertRaises

result = f(*args, kwargs)

File "twisted/python/_reflectpy3.py", line 273, in namedAny

obj = getattr(obj, n)

builtins.AttributeError: 'module' object has no attribute 'reflect_helper_IE'

Reopens: #5386 Refs: #6298

[Thijs Triemstra]

Marking this as a duplicate of #5386 and fixing the issue there.