Opened 9 years ago

Closed 9 years ago

#6273 enhancement closed fixed (fixed)

"Using SSL in Twisted" should use twisted.internet.ssl.CertificateOptions

Reported by: Hynek Schlawack Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: core Keywords: documentation
Cc: Hynek Schlawack Branch: branches/ssl-contextfactory-docs-6273-2
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Since twisted.internet.ssl.CertificateOptions is supposed to supersede twisted.internet.ssl.DefaultOpenSSLContextFactory, there should be tutorial material available instead of encouraging people using the "old way".

Change History (8)

comment:1 Changed 9 years ago by Hynek Schlawack

Cc: Hynek Schlawack added

comment:2 Changed 9 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/ssl-contextfactory-docs-6273

(In [36969]) Branching to 'ssl-contextfactory-docs-6273'

comment:3 Changed 9 years ago by Jean-Paul Calderone

Owner: set to Jean-Paul Calderone

comment:4 Changed 9 years ago by Jean-Paul Calderone

Branch: branches/ssl-contextfactory-docs-6273branches/ssl-contextfactory-docs-6273-2

(In [37494]) Branching to 'ssl-contextfactory-docs-6273-2'

comment:5 Changed 9 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

The ssl howto is now updated. Build results.

comment:6 Changed 9 years ago by Jonathan Jacobs

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks mostly good, I have a few small points:

  1. The code listing in the "startTLS server" section imports OpenSSL but doesn't seem to use it, are there side-effects to importing OpenSSL?
  1. Perhaps the code listings could benefit from using twisted.internet.task.react.

Other than that the information looks factual and I would say it is clearer now; looks good.

comment:7 Changed 9 years ago by Jean-Paul Calderone

Thanks for the review!

Perhaps the code listings could benefit from using twisted.internet.task.react.

Probably so. There are no Deferreds around to easily make the transition, though, so I'd rather leave this for another time.

comment:8 Changed 9 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [37632]) Merge ssl-contextfactory-docs-6273-2

Author: exarkun Reviewer: jonathanj Fixes: #6273

Switch the SSL howto and SSL examples from the older, less featureful SSL context factory APIs to the newer, preferred CertificateOptions API.

Note: See TracTickets for help on using tickets.