Opened 9 years ago

Closed 9 years ago

#6262 defect closed invalid (invalid)

iocp reactor unused import

Reported by: BrianM Owned by:
Priority: normal Milestone:
Component: core Keywords: iocpreactor
Cc: Branch:
Author:

Description

iocpreactor\abstract.py has this import

from twisted.internet.win32eventreactor import _ThreadedWin32EventsMixin

Although it is used as a base class it does not appear to be used at all. Is this still required?

Change History (1)

comment:1 Changed 9 years ago by Julian Berman

Resolution: invalid
Status: newclosed

Hi!

Thanks for the report.

I don't see that import in that module in current trunk: http://twistedmatrix.com/trac/browser/trunk/twisted/internet/iocpreactor/abstract.py

It appears (and is used) in iocpreactor.reactor.

In general unused imports are fine to submit patches to remove (once you've checked they're unused :) which can usually be done via a combination of running the tests / pyflakes / searching / whatever else you'd like).

Closing, feel free to comment / update if something's unclear.

Note: See TracTickets for help on using tickets.