Opened 5 years ago
Closed 5 years ago
#6236 task closed fixed (fixed)
Merge `twisted/internet/_endpointspy3.py` into `twisted/internet/endpoints.py`
| Reported by: | Jean-Paul Calderone | Owned by: | Jean-Paul Calderone |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | core | Keywords: | |
| Cc: | Branch: |
branches/endpoints-merge-6236
branch-diff, diff-cov, branch-cov, buildbot |
|
| Author: | exarkun |
Description
Also merge the associated test module. See #6183.
Change History (4)
comment:1 Changed 5 years ago by
| Author: | → exarkun |
|---|---|
| Branch: | → branches/endpoints-merge-6236 |
comment:2 Changed 5 years ago by
| Keywords: | review added |
|---|---|
| Owner: | Jean-Paul Calderone deleted |
Once this lands, reviewing #4696 will hopefully be easier.
comment:3 Changed 5 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Jean-Paul Calderone |
This seems to lack __future__ imports. (The test module lacked it to begin with, but the python3 guide seems to suggest it be there anyway).
There are also a couple of new blank line errors reported by twistedchecker in test_endpoint. All of the reported errors might as well be cleaned up now.
All of the changed code looks correct, and I did a quick scan of the copied code looking at shape, and things seem to be in order.
Please commit after fixing.
comment:4 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
(In [36683]) Branching to 'endpoints-merge-6236'