Opened 4 years ago

Closed 4 years ago

#6236 task closed fixed (fixed)

Merge `twisted/internet/_endpointspy3.py` into `twisted/internet/endpoints.py`

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/endpoints-merge-6236
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Also merge the associated test module. See #6183.

Change History (4)

comment:1 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/endpoints-merge-6236

(In [36683]) Branching to 'endpoints-merge-6236'

comment:2 Changed 4 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted

​Build results

Once this lands, reviewing #4696 will hopefully be easier.

comment:3 Changed 4 years ago by tom.prince

  • Keywords review removed
  • Owner set to exarkun

This seems to lack __future__ imports. (The test module lacked it to begin with, but the python3 guide seems to suggest it be there anyway).

There are also a couple of new blank line errors reported by twistedchecker in test_endpoint. All of the reported errors might as well be cleaned up now.

All of the changed code looks correct, and I did a quick scan of the copied code looking at shape, and things seem to be in order.

Please commit after fixing.

comment:4 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [36703]) Merge endpoints-merge-6236

Author: exarkun Reviewer: tom.prince Fixes: #6236

Re-integrate the Python 3 ported endpoints implementation into twisted/internet/endpoints.py

Note: See TracTickets for help on using tickets.