Opened 9 years ago

Closed 8 years ago

#6222 enhancement closed fixed (fixed)

Replace Deprecated Test Case Assertion Methods in twisted.names twisted.news and twisted.python

Reported by: Julian Berman Owned by: Richard Wall
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/remove-deprecated-test-methods-names-6222
branch-diff, diff-cov, branch-cov, buildbot
Author: julian

Description

See #5771

Attachments (1)

names-news-python-deprecate.patch (7.6 KB) - added by Julian Berman 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Julian Berman

comment:1 Changed 9 years ago by Tom Prince

Keywords: review removed

There are a couple of methods to be deprecated that haven't been changed. At least assertIdentical and assertNotIdentical.

comment:2 Changed 9 years ago by Tom Prince

Owner: set to Julian Berman

comment:3 Changed 8 years ago by julian

Author: julian
Branch: branches/remove-deprecated-test-methods-names-6222

(In [39018]) Branching to remove-deprecated-test-methods-names-6222.

comment:4 Changed 8 years ago by Julian Berman

Keywords: review added
Owner: Julian Berman deleted

comment:5 Changed 8 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to Richard Wall

Thanks.

I guess this is an example of a change that would be easier if we actually did the PendingDeprecationWarning step in CompatibilityPolicy. If we did, then I could turn on that warning type and run the test suite and observe that no warnings are emitted.

Oh well. This change looks great. If by some chance some method was missed then we can always deal with it later on. Please merge!

comment:6 Changed 8 years ago by julian

Resolution: fixed
Status: newclosed

(In [41086]) Merge remove-deprecated-test-methods-names-6222: Remove to-be-deprecated test methods from twisted.names

Author: Julian Reviewers: tom.prince, exarkun Fixes: #6222

Also removes the few from twisted.python. See #5771 for more info.

Note: See TracTickets for help on using tickets.