Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#6221 enhancement closed fixed (fixed)

Replace Deprecated Test Case Assertion Methods in twisted.internet

Reported by: Julian Berman Owned by: Julian Berman
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/remove-deprecated-test-methods-internet-6221
branch-diff, diff-cov, branch-cov, buildbot
Author: julian

Description

See #5771

Attachments (1)

internet-deprecate.patch (3.2 KB) - added by Julian Berman 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by Julian Berman

Attachment: internet-deprecate.patch added

comment:1 Changed 4 years ago by Tom Prince

Keywords: review removed

There are a couple of methods to be deprecated that haven't been changed. At least assertIdentical and assertNotEquals.

comment:2 Changed 4 years ago by Tom Prince

Owner: set to Julian Berman

comment:3 Changed 4 years ago by julian

Author: julian
Branch: branches/remove-deprecated-test-methods-internet-6221

(In [38991]) Branching to remove-deprecated-test-methods-internet-6221.

comment:4 Changed 4 years ago by Julian Berman

Keywords: review added
Owner: Julian Berman deleted

Up for review.

See list of substitutions in #6220 if you'd like the list of what should be being replaced.

Build results

comment:5 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: set to Julian Berman

This looks good, thanks. Please merge after adding a news file.

comment:6 Changed 4 years ago by julian

Resolution: fixed
Status: newclosed

(In [39017]) Merge remove-deprecated-test-methods-internet-6221: Replace to-be-deprecated assertions in twisted.internet

Author: Julian Reviewers: tom.prince Fixes: #6221

Replace older test method assertions like fail* (which are soon to be deprecated) in twisted.internet's test suite with their newer equivalents.

comment:7 Changed 4 years ago by Julian Berman

Thanks Tom!

Note: See TracTickets for help on using tickets.