Opened 9 years ago

Closed 9 years ago

#6158 enhancement closed fixed (fixed)

Port twisted.python.util.nameToLabel to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/nameToLabel-py3-6158
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst


nameToLabel is required by, so should be ported to Python 3.

Change History (5)

comment:1 Changed 9 years ago by itamarst

Author: itamarst
Branch: branches/nameToLabel-py3-6158

(In [36248]) Branching to 'nameToLabel-py3-6158'

comment:2 Changed 9 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: set to Jean-Paul Calderone

Ready for review, tests are running -

This is a trivial port.

comment:3 Changed 9 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

nameToLabel seems to be missing some test coverage. Add it now if you feel like it, otherwise file a ticket for addressing that.

Should we start a section in the porting howto that's just a list of APIs which took str before and changed to take str in Python 3?

Otherwise looks good, please merge when you're happy with respect to these two points.

comment:4 Changed 9 years ago by Itamar Turner-Trauring

  1. #6160
  2. We already have some things, I thought, like log.msg()? In this particular case, however, the API documentation is very clear that it takes a "string that could be a Python identifier", so the behaviour on Python 3 should be clear to anyone who's used this API before.

comment:5 Changed 9 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [36251]) Merge nameToLabel-py3-6158.

Author: itamar Review: exarkun Fixes: #6158

Port twisted.python.util.nameToLabel to Python 3.

Note: See TracTickets for help on using tickets.