Opened 4 years ago

Closed 4 years ago

#6109 enhancement closed fixed (fixed)

Port twisted.protocols.loopback to Python 3

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/loopback-py3-6109-2
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Some HTTP tests use it, so it would at least help get full test coverage for Twisted Web.

Change History (7)

comment:1 Changed 4 years ago by Jean-Paul Calderone

Milestone: Python-3.xPython 3.3 Minimal
Owner: set to Jean-Paul Calderone
Status: newassigned

SSL unit tests also need this, so I guess it is part of the minimal subset.

comment:2 Changed 4 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/loopback-py3-6109

(In [36183]) Branching to 'loopback-py3-6109'

comment:3 Changed 4 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring
Status: assignednew

Build results. Test coverage for loopbackAsync seems pretty good, and that's all we care about I think.

comment:4 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review removed
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

Thanks!

  1. LoopbackRelay has a bunch of strings that need to be converted to bytes.
  2. Open a ticket for missing tests.

Fix, then merge.

comment:5 Changed 4 years ago by Jean-Paul Calderone

Branch: branches/loopback-py3-6109branches/loopback-py3-6109-2

(In [36199]) Branching to 'loopback-py3-6109-2'

comment:6 Changed 4 years ago by Jean-Paul Calderone

Thanks!

LoopbackRelay has a bunch of strings that need to be converted to bytes.

Moved the module to the not-quite-ported list instead - r36201.

Open a ticket for missing tests.

Opened #6138

comment:7 Changed 4 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [36203]) Merge loopback-py3-6109-2

Author: exarkun Reviewer: itamarst Fixes: #6109

Port twisted.protocols.loopback.loopbackAsync to Python 3.

Note: See TracTickets for help on using tickets.