Opened 4 years ago

Closed 4 years ago

#6091 enhancement closed fixed (fixed)

Remove (immediately and with all haste) `IResolver.lookupRecord`

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/remove-lookuprecord-6091
(github, coverage, patch, buildbot, log)
Author: exarkun

Description (last modified by exarkun)

This method of the IResolver interface has no implementation in Twisted and has never had an implementation in Twisted. It is a documentation error.

I propose that this is acceptable without deprecation because:

  • Twisted has never included an implementation of this method for applications to call.
  • Twisted has never called this method on any object, either defined by Twisted or supplied by an application.
  • It is redundant with query.
  • Any application code which was implementing this method for some reason of its own will be unaffected by the removal of the method from the interface.

Change History (4)

comment:1 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/remove-lookuprecord-6091

(In [36047]) Branching to 'remove-lookuprecord-6091'

comment:2 Changed 4 years ago by exarkun

  • Description modified (diff)
  • Keywords review added
  • Owner changed from exarkun to itamar

There, I removed it. No deprecation or anything, just bam gone.

comment:3 Changed 4 years ago by therve

  • Keywords review removed
  • Owner changed from itamar to exarkun

I like it. Please merge.

comment:4 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [36069]) Merge remove-lookuprecord-6091

Author: exarkun Reviewer: therve Fixes: #6091

Remove twisted.internet.interfaces.IResolver.lookupRecord, a bogus method that was never implemented or used.

Note: See TracTickets for help on using tickets.