Opened 5 years ago

Closed 5 years ago

#6069 enhancement closed fixed (fixed)

Port twisted.internet.test.test_tcp and connectionmixins to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/tcp-py3-6069-3
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description (last modified by Itamar Turner-Trauring)

In the interest of making #6002 smaller, twisted.internet.test.test_tcp and twisted.internet.test.connectionmixins should be ported to Python 3 on their own.

Change History (7)

comment:1 Changed 5 years ago by itamarst

Author: itamarst
Branch: branches/tcp-py3-6069

(In [35994]) Branching to 'tcp-py3-6069'

comment:2 Changed 5 years ago by Itamar Turner-Trauring

Description: modified (diff)

comment:3 Changed 5 years ago by itamarst

Branch: branches/tcp-py3-6069branches/tcp-py3-6069-2

(In [36084]) Branching to 'tcp-py3-6069-2'

comment:4 Changed 5 years ago by itamarst

Branch: branches/tcp-py3-6069-2branches/tcp-py3-6069-3

(In [36157]) Branching to 'tcp-py3-6069-3'

comment:5 Changed 5 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

Ready for review, I think. http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/tcp-py3-6069-3

Only non-test code change was changing order of checks in abstract.py so that you don't compare ConnectionLost to an integer, which fails on Python 3.

comment:6 Changed 5 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

Thanks.

  1. Maybe connect in twisted/internet/test/test_tcp.py should have a docstring, at least describing what shape destination should have, now that it is less self-describing in the signature.
  2. Add a reference to #6070 to the chr function in posixifaces.py.

That's all. Please merge after fixing the above.

comment:7 Changed 5 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [36190]) Merge tcp-py3-6069-3.

Author: itamar Review: exarkun Fixes: #6069

twisted.internet.test.test_tcp is now ported to Python 3.

Note: See TracTickets for help on using tickets.