Opened 4 years ago

Closed 4 years ago

#6068 enhancement closed fixed (fixed)

Port select, poll and epoll reactors to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/reactors-py3-6068
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description

We've got enough test coverage at this point in trunk, or branches, that porting select, poll and epoll seems reasonable.

Change History (5)

comment:1 Changed 4 years ago by itamarst

Author: itamarst
Branch: branches/reactors-py3-6068

(In [35992]) Branching to 'reactors-py3-6068'

comment:2 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

comment:3 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

Urrr really? How is that possible? I guess even if the modules are "ported" that doesn't mean the reactor-related tests in twisted.internet.test are passing. So... okay? I guess? Clearly I'm slightly confused by this, but it doesn't seem wrong... Go ahead and merge, if you know where you're going next (maybe write down where you're going next though).

comment:4 Changed 4 years ago by Itamar Turner-Trauring

These modules only really provide IReactorFDSet, so it seems reasonable to merge this once test_udp and test_tcp are passing.

comment:5 Changed 4 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [36155]) Merge reactors-py3-6068.

Author: itamar Review: exarkun Fixes: #6068

select, poll and epoll reactors are deemed to be sufficiently working on Python 3, given passing TCP, UDP and fdset tests.

Note: See TracTickets for help on using tickets.