#6065 enhancement closed fixed (fixed)
Port twisted.internet.base to Python 3
Reported by: | Itamar Turner-Trauring | Owned by: | Itamar Turner-Trauring |
---|---|---|---|
Priority: | normal | Milestone: | Python 3.3 Minimal |
Component: | core | Keywords: | |
Cc: | Branch: |
branches/base-py3-6065-2
branch-diff, diff-cov, branch-cov, buildbot |
|
Author: | itamarst |
Description
twisted.internet.base
should run on Python 3.
Change History (15)
comment:1 Changed 6 years ago by
Author: | → itamarst |
---|---|
Branch: | → branches/base-py3-6065 |
comment:2 Changed 6 years ago by
Keywords: | review added |
---|---|
Owner: | set to Jean-Paul Calderone |
comment:4 Changed 6 years ago by
Keywords: | review removed |
---|
Taking it back from review, discovered another relevant test module.
comment:5 Changed 6 years ago by
Keywords: | review added |
---|
OK, started another build:
http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/base-py3-6065
comment:6 Changed 6 years ago by
Keywords: | review removed |
---|---|
Owner: | changed from Jean-Paul Calderone to Itamar Turner-Trauring |
Thanks.
DelayedCallTests
intwisted.test.test_internet
belongs somewhere else I think.twisted.internet.test.test_time
? Ortwisted.internet.test.test_base
(only because, perhaps, it's something of a stretch for an interface test).- What about
twisted.internet.test.test_base
? That seems like an important part of portingtwisted.internet.base
... - Some of the process code in
twisted.internet.base
looks like it won't work on Python 3 - it usesunicode
but doesn't importtwisted.python.compat.unicode
. Perhaps that's fine for now, since porting process support does seem like a fairly separate task. So maybe this ticket is just "port some of twisted.internet.base". - Maybe
TestProducer._dontPausePullConsumerTest
should have a docstring now, at least documenting the allowed values formethodName
.
comment:8 Changed 6 years ago by
Keywords: | review added |
---|---|
Owner: | changed from Itamar Turner-Trauring to Jean-Paul Calderone |
- That already had a test for this, so just deleted one I added.
- Oops. Added.
- I updated the test description to note that it doesn't include process code, and I reverted the changes I made to process code in
base
. - Added.
Ready for review, I think: http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/base-py3-6065
comment:9 Changed 6 years ago by
Keywords: | review removed |
---|---|
Owner: | changed from Jean-Paul Calderone to Itamar Turner-Trauring |
- The
pass
in the body ofnothing
intest_base.py
is unneeded. Hooray docstrings. - There's a merge conflict in the howto.
Otherwise looks good. Please merge when these are addressed.
comment:10 Changed 6 years ago by
Branch: | branches/base-py3-6065 → branches/base-py3-6065-2 |
---|
(In [36077]) Branching to 'base-py3-6065-2'
comment:11 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:12 Changed 5 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I don't believe that twisted.internet.base
is completely ported to Python3. In particular, there are mentions of str
and unicode
in the file that correspond to Python2 usage.
comment:13 Changed 5 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
I don't think we're going to back out this branch at this point, though. I'm going to close this and open a new ticket.
comment:14 Changed 5 years ago by
To elaborate on itamar's comment somewhat:
Thanks for your interest in this area of Twisted, garrison.
The workflow used for the ticket tracker is to only re-open fixed tickets if the corresponding change to trunk is also being reverted.
Given how long has elapsed since this change was made (it has been included in releases, later changes have been based on it, etc) it's not likely we'll revert the code.
Please file new tickets specifically describing the remaining issues (unless itamar does it for you).
Thanks again.
(In [35978]) Branching to 'base-py3-6065'