Opened 9 years ago

Closed 9 years ago

#6059 enhancement closed fixed (fixed)

Port twisted.names.common to Python 3

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone: Python 3.3 Minimal
Component: names Keywords:
Cc: Branch: branches/dns-common-py3-6059
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun


This is needed by twisted.names.client.

Change History (4)

comment:1 Changed 9 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/dns-common-py3-6059

(In [36015]) Branching to 'dns-common-py3-6059'

comment:2 Changed 9 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

Okay, there's some stuff. Pretty straight-forward. This ports twisted.names.error as well, since that ended up not needing much porting and has no dedicated test module of its own. The test coverage here isn't great, but other parts of Twisted Names test suite exercise this code somewhat more, so when those are ported the coverage will improve. I think maybe that's an okay approach for this code. Build results

comment:3 Changed 9 years ago by Itamar Turner-Trauring

Keywords: review removed
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone
  1. Two news files.
  2. You should verify in the tests that the result of ResolverBase.query is the result of the underlying function being called.
  3. extractRecords only has very implicit test coverage at best, it seems. At the very least you should open a ticket for that, if it's not needed for the use cases we're covering.

Other than that looks good, please merge.

comment:4 Changed 9 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [36039]) Merge dns-common-py3-6059

Author: exarkun Reviewer: itamarst Fixes: #6058 Fixes: #6059

Port twisted.names.error (trivial) and twisted.names.common to Python 3. Also improve some of the test coverage and fix a few structural documentation errors.

Note: See TracTickets for help on using tickets.