Opened 6 years ago

Closed 5 years ago

Last modified 20 months ago

#6051 defect closed fixed (fixed)

twisted.trial.test.test_tests doesn't follow the coding standard

Reported by: Itamar Turner-Trauring Owned by: Wilfredo Sánchez Vega
Priority: normal Milestone:
Component: trial Keywords:
Cc: Jonathan Lange Branch:
Author:

Description

twisted.trial.test.test_tests should follow the coding standard. All tests should have docstrings, their name should start with test_, etc..

Attachments (1)

ticket-6051-docs.patch​ (29.2 KB) - added by Ken 5 years ago.
patch to make twisted/trial/test/test_tests.py comply to standard.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by DefaultCC Plugin

Cc: Jonathan Lange added

comment:2 Changed 5 years ago by weiteng

Owner: set to weiteng

comment:3 Changed 5 years ago by weiteng

Owner: weiteng deleted

comment:4 Changed 5 years ago by Ken

Owner: set to Ken
Status: new → assigned

comment:5 Changed 5 years ago by Ken

Present style dings:

  • Docstrings:
    • I am assuming that all those "See Module Docstrings" are not OK.
    • Some functions are missing docstrings altogether.
  • Naming
    • Some functions named testBlah instead of test_blah

Changed 5 years ago by Ken

Attachment: ticket-6051-docs.patch​ added

patch to make twisted/trial/test/test_tests.py comply to standard.

comment:6 Changed 5 years ago by Ken

Keywords: review added; easy removed
Owner: Ken deleted
Status: assigned → new

the ClassTest in GCMixin seems to be unnecessary and doesn't break anything. Am I right about this?

Should be nothing but formatting and comments otherwise..

comment:7 Changed 5 years ago by Wilfredo Sánchez Vega

Very nice. +1.

comment:8 Changed 5 years ago by Wilfredo Sánchez Vega

Owner: set to Wilfredo Sánchez Vega
Status: new → assigned

comment:9 Changed 5 years ago by Wilfredo Sánchez Vega

Resolution: → fixed
Status: assigned → closed

(In [37638]) Apply ticket-6051-docs.patch: Add docs to test_tests.

Author: wirehead Reviewer: wsanchez Fixes: #6051

Make twisted/trial/test/test_tests.py comply to standard.

comment:10 Changed 20 months ago by hawkowl

Keywords: review removed

[mass edit] Removing review from closed tickets.

Note: See TracTickets for help on using tickets.