Opened 5 years ago

Closed 5 years ago

#6028 enhancement closed wontfix (wontfix)

Documentation for request encoders points to wrong interfaces

Reported by: therve Owned by: therve
Priority: normal Milestone:
Component: web Keywords: documentation easy
Cc: jknight Branch: branches/fix-encoder-doc-6028
branch-diff, diff-cov, branch-cov, buildbot
Author: therve

Description

When merging #104 I kept wrong links to interfaces when renaming them, it should be fxied. OTOH I'm not sure pointing to private interfaces is really useful.

Change History (6)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 5 years ago by therve

Author: therve
Branch: branches/fix-encoder-doc-6028

(In [35843]) Branching to 'fix-encoder-doc-6028'

comment:3 Changed 5 years ago by therve

Keywords: easy review added

i removed the references as it seems more clear to me.

comment:4 Changed 5 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to therve

Fix seems correct as far as it goes.

However I have a concern about #104, related to the SSL/zlib CRIME attack. I wonder if the encoders argument to Site is safe at all (if it isn't, then maybe it's not worth applying documentation fixes).

comment:5 Changed 5 years ago by Jean-Paul Calderone

therve offered to introduce a more focusable API for encoders before the next Twisted release, or revert the original merge to avoid committing us to supporting it. That seems fine to me. So, go ahead and merge this if you like (and please file a ticket for that adjusted API). Thanks!

comment:6 Changed 5 years ago by therve

Resolution: wontfix
Status: newclosed

I'll fix the documentation in the new ticket, #6031.

Note: See TracTickets for help on using tickets.