Opened 4 years ago

Closed 4 years ago

#6023 enhancement closed fixed (fixed)

Port twisted.internet.test.test_udp and test_udp_internals to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/testudp-py3-6023
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description

Unfortunately twisted.internet.test.test_udp and test_udp_internals don't provide enough coverage to prove UDP works (that'll need to wait for twisted.test.test_udp which depends on TestCase), but they should be ported.

Change History (4)

comment:1 Changed 4 years ago by itamarst

Author: itamarst
Branch: branches/testudp-py3-6023

(In [35826]) Branching to 'testudp-py3-6023'

comment:2 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: set to Jean-Paul Calderone

comment:3 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring
  1. __future__ imports missing here and there
  2. Would be nice to have a ticket link in the comment in test_unregisterProducerAfterDisconnect in connectionmixins.py

Otherwise looks good, merge when the above are addressed.

comment:4 Changed 4 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [35838]) Merge testudp-py3-6023.

Author: itamar Review: exarkun Fixes: #6023

Port twisted.internet.test.test_udp and test_udp_internals to Python 3.

Note: See TracTickets for help on using tickets.