Opened 5 years ago

Closed 5 years ago

#5975 enhancement closed fixed (fixed)

Port twisted.python.threadpool to Python 3

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/threadpool-py3-5975-2
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description

twisted.python.threadpool is used by the reactor for the default DNS lookups implementation, and therefore needs to be ported.

Change History (6)

comment:1 Changed 5 years ago by itamarst

Author: itamarst
Branch: branches/threadpool-py3-5975

(In [35636]) Branching to 'threadpool-py3-5975'

comment:2 Changed 5 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: set to Jean-Paul Calderone

comment:3 Changed 5 years ago by Jean-Paul Calderone

Status: newassigned

comment:4 Changed 5 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring
Status: assignednew
  1. There's a conflict in _twistedpython3.py.
  2. The _waitForLock change allocates an extra 30MB of memory on Python 2. Can we do this loop without that extra cost?
  3. I bet some parts of threadpool.py would be clearer with context managers. For example, in _worker, with working(self): ... instead of matched append/remove calls. Would make a good ticket.

Uhh otherwise I guess this looks okay. Please merge after addressing the above.

comment:5 Changed 5 years ago by itamarst

Branch: branches/threadpool-py3-5975branches/threadpool-py3-5975-2

(In [35654]) Branching to 'threadpool-py3-5975-2'

comment:6 Changed 5 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [35657]) Merge threadpool-py3-5975-2.

Author: itamar Review: exarkun Fixes: #5975

Port twisted.python.threadpool to Python 3.

Note: See TracTickets for help on using tickets.