Opened 5 years ago

Closed 4 years ago

#5960 enhancement closed fixed (fixed)

Port twisted.python.lockfile to Python 3

Reported by: Itamar Turner-Trauring Owned by: therve
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: branches/lockfile-py3-5960
branch-diff, diff-cov, branch-cov, buildbot
Author: therve

Description

lockfile is required by trial (and technically twisted.internet.defer). We could probably work around it but it's trivial to port.

Attachments (2)

lockfile-r0.patch (3.1 KB) - added by James Broadhead 4 years ago.
lockfile-r1.patch (19.5 KB) - added by James Broadhead 4 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by Itamar Turner-Trauring

This should also add Python 3 support for twisted.internet.defer.DeferredFilesystemLock.

comment:2 Changed 5 years ago by Itamar Turner-Trauring

Milestone: Python 3.3 MinimalPython-3.x

comment:3 Changed 5 years ago by Itamar Turner-Trauring

Owner: Itamar Turner-Trauring deleted

Changed 4 years ago by James Broadhead

Attachment: lockfile-r0.patch added

comment:4 Changed 4 years ago by James Broadhead

Keywords: review added

comment:5 Changed 4 years ago by James Broadhead

Keywords: review removed

Changed 4 years ago by James Broadhead

Attachment: lockfile-r1.patch added

comment:6 Changed 4 years ago by James Broadhead

Keywords: review added

comment:7 Changed 4 years ago by therve

Author: therve
Branch: branches/lockfile-py3-5960

(In [39100]) Branching to 'lockfile-py3-5960'

comment:8 Changed 4 years ago by therve

Owner: set to therve

Looks great, applying!

comment:9 Changed 4 years ago by therve

Keywords: review removed

comment:10 Changed 4 years ago by therve

Resolution: fixed
Status: newclosed

(In [39103]) Merge lockfile-py3-5960

Author: jamesbroadhead Reviewer: therve Fixes: #5960

Port twisted.python.lockfile to python3.

Note: See TracTickets for help on using tickets.