Opened 7 years ago

Closed 7 years ago

#5881 defect closed fixed (fixed)

Fix conch --auth

Reported by: Ying Li Owned by: Ying Li
Priority: normal Milestone:
Component: conch Keywords: easy
Cc: z3p Branch: branches/fix-conch-auth-5881
branch-diff, diff-cov, branch-cov, buildbot
Author: cyli

Description

I broke the --auth option in #4753. Normally it's possible to add multiple credentials checker using the strcred Options mixin. The override of addChecker in conch means that each new --auth option overrides the previous one, so only one checker can be added.

Fix this.

Change History (7)

comment:1 Changed 7 years ago by DefaultCC Plugin

Cc: z3p added

comment:2 Changed 7 years ago by Ying Li

Type: enhancement → defect

comment:3 Changed 7 years ago by Ying Li

Author: → cyli
Branch: → branches/fix-conch-auth-5881

(In [35290]) Branching to 'fix-conch-auth-5881'

comment:4 Changed 7 years ago by Ying Li

(In [35293]) Only clear out existing checkers if adding checkers for the first time refs #5881

comment:5 Changed 7 years ago by Ying Li

Keywords: easy review added

​build results

comment:6 Changed 7 years ago by Glyph

Keywords: review removed
Owner: set to Ying Li

Tests pass, fix looks pretty straightforward; merge away.

comment:7 Changed 7 years ago by Ying Li

Resolution: → fixed
Status: new → closed

(In [35300]) Merge fix-conch-auth-5881: allow multiple --auth parameters to be passed

Author: cyli Reviewer: glyph Fixes: #5881

Override default checkers if 1 --auth parameter is passed, but allow multiple --auth parameters to add multiple checkers

Note: See TracTickets for help on using tickets.