Opened 4 years ago

Closed 4 years ago

#5878 defect closed fixed (fixed)

AdoptedStreamServerEndpoint does not implement twisted.internet.interfaces.IStreamServerEndpoint

Reported by: ashfall Owned by: ashfall
Priority: high Milestone:
Component: core Keywords: endpoint
Cc: Thijs Triemstra Branch: branches/interface-test-server-endpoint-5878
branch-diff, diff-cov, branch-cov, buildbot
Author: ashfall

Description (last modified by ashfall)

Also, ServerEndpointTestCaseMixin needs to have a test that checks if the endpoints provide interfaces.IStreamServerEndpoint

Change History (5)

comment:1 Changed 4 years ago by ashfall

Author: ashfall
Branch: branches/interface-test-server-endpoint-5878

(In [35272]) Branching to 'interface-test-server-endpoint-5878'

comment:2 Changed 4 years ago by ashfall

Description: modified (diff)
Summary: ServerEndpointTestCaseMixin needs to have a test that checks if the endpoints provide interfaces.IStreamServerEndpointAdoptedStreamServerEndpoint does not implement twisted.internet.interfaces.IStreamServerEndpoint

comment:3 Changed 4 years ago by ashfall

Keywords: review added
Owner: ashfall deleted

comment:4 Changed 4 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review removed
Owner: set to ashfall

Thanks. Please merge.

comment:5 Changed 4 years ago by ashfall

Resolution: fixed
Status: newclosed

(In [35560]) Merge interface-test-server-endpoint-5878: AdoptedStreamServerEndpoint now implements twisted.internet.interfaces.IStreamServerEndpoint

Author: ashfall Reviewer: thijs Fixes: #5878

Note: See TracTickets for help on using tickets.