Opened 4 years ago

Closed 14 months ago

#5875 defect closed wontfix (wontfix)

tap2rpm assumes $PREFIX is /usr

Reported by: Henry Stern Owned by: Henry Stern
Priority: normal Milestone:
Component: core Keywords:
Cc: Thijs Triemstra Branch:
Author:

Description

The RPMs and init scripts created by tap2rpm use a hard-coded path to twistd. This does not work if you have installed python and Twisted under a different prefix.

Attached is a patch that makes an intelligent guess at the path to twistd and includes it in the .spec and init script.

Attachments (3)

tap2rpm-hestern.patch (1.5 KB) - added by Henry Stern 4 years ago.
tap2rpm-hestern.2.patch (1.1 KB) - added by Henry Stern 4 years ago.
Fixed tap2rpm patch. Ignore earlier.
tap2rpm-hestern.3.patch (2.0 KB) - added by Henry Stern 4 years ago.
Third time's the charm.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by Henry Stern

Attachment: tap2rpm-hestern.patch added

Changed 4 years ago by Henry Stern

Attachment: tap2rpm-hestern.2.patch added

Fixed tap2rpm patch. Ignore earlier.

Changed 4 years ago by Henry Stern

Attachment: tap2rpm-hestern.3.patch added

Third time's the charm.

comment:1 Changed 4 years ago by Jean-Paul Calderone

Keywords: review added

Thanks. Please make sure to add the "review" keyword, otherwise the patch will vanish into the mountain of thousands of other open tickets in the issue tracker.

comment:2 Changed 4 years ago by Stephen Thorne

Keywords: review removed

Before this patch can be accepted there will need to be tests written.

comment:3 Changed 4 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Owner: set to Henry Stern

comment:4 Changed 14 months ago by hawkowl

Resolution: wontfix
Status: newclosed

tap2rpm is deprecated, so closing as wontfix.

Note: See TracTickets for help on using tickets.