Opened 5 years ago

Closed 4 years ago

#5864 task closed fixed (fixed)

Remove a sha1 import from < 2.5

Reported by: Julian Berman Owned by: Tom Prince
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch: branches/sha1-py25-5864
branch-diff, diff-cov, branch-cov, buildbot
Author: Julian

Description

Simple removal of an import of sha1 from pre-2.5.

Attachments (1)

knownhosts-24.patch (568 bytes) - added by Julian Berman 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: z3p added

Changed 5 years ago by Julian Berman

Attachment: knownhosts-24.patch added

comment:2 Changed 5 years ago by Vladimir Perić

Keywords: review removed
Owner: set to Julian Berman
Summary: Remove a sha1 import from < 2.4Remove a sha1 import from < 2.5

Looks good to me.

Also, while I think small tickets are great, this is *really* small. Perhaps it would be better to work on tickets #5386 and #5837, which are about this but for the whole of Twisted. Grouping it by module might also work well.

comment:3 Changed 5 years ago by Julian Berman

Hey, thanks for the review :).

These three were small fixes that were just easy enough to do while I had these modules open for another reason, I've got a couple of other larger issues that I've been working on.

I don't have merge rights I don't think, so if you happen to and have a moment that'd be nice :). Thanks again.

comment:4 Changed 4 years ago by Thijs Triemstra

Author: thijs
Branch: branches/sha1-py25-5864

(In [37019]) Branching to 'sha1-py25-5864'

comment:5 Changed 4 years ago by Thijs Triemstra

Author: thijsJulian
Keywords: review added
Owner: Julian Berman deleted
Type: enhancementtask

Forced a build.

comment:6 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: set to Tom Prince

Merging: build looks clean, and vperic already gave this a good review.

comment:7 Changed 4 years ago by Tom Prince

Resolution: fixed
Status: newclosed

(In [37119]) Merge sha1-py25-5864: Simple removal of an import of sha1 from pre-2.5.

Author: Julian Reviewers: vperic Fixes: #5864

Note: See TracTickets for help on using tickets.