replace usage of file with FilePath in twisted.mail

[Thijs Triemstra]

The usage of file should be replaced with FilePath in twisted.mail and it's tests for Python 3 compatibility.

twisted/mail/test/test_options.py:31:        aliasFile = file(self.aliasFilename, 'w')
twisted/mail/test/test_mail.py:169:        self.f = file(self.name, 'w')
twisted/mail/test/test_mail.py:540:            fObj = file(j(self.d, f), 'w')
twisted/mail/test/test_mail.py:856:            f = file(name + '-H', 'w')
twisted/mail/test/test_mail.py:860:            f = file(name + '-D', 'w')
twisted/mail/test/test_mail.py:1693:        lines = file(tmpfile).readlines()
twisted/mail/test/test_mail.py:1845:            lines = file('process.alias.out').readlines()
twisted/mail/test/test_imap.py:1563:            message = file(infile)
twisted/mail/alias.py:70:        fp = file(filename)
twisted/mail/alias.py:155:            f = file(self.finalname, 'a')
twisted/mail/alias.py:403:                    f = file(addr[1:])

[Antoine Pitrou]

When using pickle.dump, you want to use open mode "wb", not "w". Otherwise, looks good.

[Thijs Triemstra]

(In [35027]) Branching to 'mail-filepath-5809'

[Thijs Triemstra]

(In [35029]) replace the usage of file with FilePath in twisted.mail, refs #5809

[Thijs Triemstra]

​Build results.

[argonemyth]

Hey thijs,

Thanks for updating the mail component with FilePath. I found two little things might take you 5 minutes to correct.

1. There is still a file object lingering around:

​http://twistedmatrix.com/trac/browser/branches/mail-filepath-5809/twisted/mail/test/test_mail.py#L202

2. You don't need to add "b" in test_mail.RelayerTestCase like antoine said in comment:3. As the file is always opened in binary mode if you use FilePath.open().

That's all, thanks you again!

[moijes12]

tried to add argonemyth's suggestions

[moijes12]

Patch was build against the branch.

[moijes12]

Make that patch was created against the branch branches/mail-filepath-5809.

[Jean-Paul Calderone]

Thanks. The change still seems incomplete though. FilePath should be used, not open. This will also fix a related problem, which is that open(...).read() relies on the garbage collector to close the file, which takes a while on PyPy and generates a warning on Python 3.

[therve]

Following Plan/Python3 I'm closing this ticket. Sorry for the inconvenience.