Opened 7 years ago
Closed 6 years ago
#5801 defect closed fixed (fixed)
Missing test coverage for SSL client endpoint string description parser
| Reported by: | Jean-Paul Calderone | Owned by: | Tom Prince |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | core | Keywords: | endpoints easy |
| Cc: | Branch: |
branches/ssl-client-endpoint-parser-test-5801-2
branch-diff, diff-cov, branch-cov, buildbot |
|
| Author: | ashfall, tomprince |
Description
The default for certKey is untested, as is the default for sslmethod.
Attachments (1)
Change History (8)
comment:1 Changed 7 years ago by
| Owner: | set to ashfall |
|---|
comment:2 Changed 7 years ago by
| Author: | → ashfall |
|---|---|
| Branch: | → branches/ssl-client-endpoint-parser-test-5801 |
(In [34995]) Branching to 'ssl-client-endpoint-parser-test-5801'
Changed 6 years ago by
| Attachment: | ssl-client-endpoint-test-defaults-5801.patch added |
|---|
comment:3 Changed 6 years ago by
| Keywords: | review added |
|---|---|
| Owner: | ashfall deleted |
Added a new test which tests that default values for the ssl client endpoint string parser are set.
comment:4 Changed 6 years ago by
| Author: | ashfall → ashfall, tomprince |
|---|---|
| Branch: | branches/ssl-client-endpoint-parser-test-5801 → branches/ssl-client-endpoint-parser-test-5801-2 |
(In [37818]) Branching to ssl-client-endpoint-parser-test-5801-2.
comment:5 Changed 6 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Tom Prince |
This looks good. I've slightly expanded the docstring, to be more precise. I'll merge this.
comment:7 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
This looks like something I do a lot.