Opened 6 years ago
Closed 6 years ago
#5766 task closed fixed (fixed)
Remove deprecated unzip and unzipIter in twisted.python.zipstream
| Reported by: | Thijs Triemstra | Owned by: | Thijs Triemstra |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | core | Keywords: | |
| Cc: | Thijs Triemstra | Branch: |
branches/remove-unzip-5766
branch-diff, diff-cov, branch-cov, buildbot |
| Author: | thijs |
Description (last modified by )
unzip and unzipIter in twisted.python.zipstream were deprecated in Twisted 11.0 and can be removed.
Same goes for countZipFileEntries, deprecated in r22464.
Attachments (1)
Change History (7)
Changed 6 years ago by
| Attachment: | zipstream-5766.patch added |
|---|
comment:1 Changed 6 years ago by
| Author: | → thijs |
|---|---|
| Description: | modified (diff) |
| Keywords: | review added |
comment:2 Changed 6 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Thijs Triemstra |
comment:3 Changed 6 years ago by
| Branch: | → branches/remove-unzip-5766 |
|---|
(In [35093]) Branching to 'remove-unzip-5766'
comment:4 Changed 6 years ago by
comment:5 Changed 6 years ago by
| Status: | new → assigned |
|---|
Thanks for the review. The patch was committed without the punctuation changes: Build results.
comment:6 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
The capitalization and punctuation changes in this patch are questionable. If they came with improvements to the actual content of the documentation itself, I'd be happy to accept them. Twiddling with periods for its own sake strikes me as a great waste of time though.
Please put this patch in a branch and verify that it passes on all builders. If it does, go ahead and merge.