Opened 7 years ago

Last modified 7 years ago

#5719 enhancement new

Add a string endpoint description plugin for twisted.internet.endpoints.TCP6ClientEndpoint

Reported by: ashfall Owned by: ashfall
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/str-desc-plugin-tcp6clientendpoint-5719
branch-diff, diff-cov, branch-cov, buildbot
Author: ashfall


A string endpoint description plugin for the TCP client endpoint that supports IPv6 addresses (#5695) is needed so that the endpoint is accessible from the command-line.

Change History (4)

comment:1 Changed 7 years ago by ashfall

Owner: set to ashfall

comment:2 Changed 7 years ago by ashfall

Author: ashfall
Branch: branches/str-desc-plugin-tcp6clientendpoint-5719

(In [35060]) Branching to 'str-desc-plugin-tcp6clientendpoint-5719'

comment:3 Changed 7 years ago by ashfall

Keywords: review added
Owner: ashfall deleted

comment:4 Changed 7 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to ashfall

Thanks. Sorry about the extreme delay in the review.

  1. The comment in TCP6ClientEndpointPluginTests.test_stringDescription is in a weird place. Usually we put comments before the code they're related to.
  2. It'd be nice to have a test that exercises the defaults for timeout and bindAddress.

It's slightly sad to see another instance of a parser that can't properly use the proper reactor. Perhaps it'd be nice to prioritize #5870 above more client endpoint parser plugins.

Note: See TracTickets for help on using tickets.