Opened 9 years ago

Closed 9 years ago

#5602 defect closed fixed (fixed)

twisted/web/_newclient.py uses invalid type in docstring

Reported by: Jean-Paul Calderone Owned by: Thijs Triemstra
Priority: normal Milestone:
Component: web Keywords: documentation
Cc: jknight Branch:
Author:

Description

Request.persistent is documented with @type persistent: Boolean

Boolean is not a Python type. This should be C{bool}.

Attachments (4)

5602.patch (873 bytes) - added by Amit Chhabra 9 years ago.
5602.misc (123 bytes) - added by Amit Chhabra 9 years ago.
5602.2.patch (888 bytes) - added by Amit Chhabra 9 years ago.
5602.2.misc (127 bytes) - added by Amit Chhabra 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by DefaultCC Plugin

Cc: jknight added

Changed 9 years ago by Amit Chhabra

Attachment: 5602.patch added

Changed 9 years ago by Amit Chhabra

Attachment: 5602.misc added

comment:2 Changed 9 years ago by Amit Chhabra

Keywords: review added

Changed 9 years ago by Amit Chhabra

Attachment: 5602.2.patch added

Changed 9 years ago by Amit Chhabra

Attachment: 5602.2.misc added

comment:3 Changed 9 years ago by Thijs Triemstra

Keywords: review removed
Owner: set to Thijs Triemstra
Status: newassigned

Thanks for the patch. I'll appply 5602.2.patch but use an empty .misc file, as explained on ReviewProcess#Newsfiles.

comment:4 Changed 9 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [34126]) Apply 5602.2.patch: Correct epytext for persistent in the docstring of t.web._newclient.Request.

Author: chhabraamit Reviewer: thijs Fixes: #5602

Note: See TracTickets for help on using tickets.