Opened 4 years ago

Closed 4 years ago

#5598 defect closed fixed (fixed)

UserWarning has reference to removed twisted.im

Reported by: thijs Owned by: exarkun
Priority: normal Milestone:
Component: words Keywords: easy
Cc: thijs, ralphm Branch:
Author:

Description

There's a reference in t.words.im that references the old twisted.im package, instead of twisted.words.im.

$ python doc/words/examples/minchat.py 
/home/thijs/workspaces/opensource/software/twisted/svn/Twisted/trunk/twisted/words/im/__init__.py:8: UserWarning: twisted.im will be undergoing a rewrite at some point in the future.

Attachments (3)

warrningCorrection.diff (707 bytes) - added by chhabraamit 4 years ago.
5598.removal (93 bytes) - added by chhabraamit 4 years ago.
newCorrectedPatch.diff (689 bytes) - added by chhabraamit 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by DefaultCC Plugin

  • Cc ralphm added

comment:2 Changed 4 years ago by glyph

This warning should just be removed. We are not going to rewrite twisted.im or twisted.words.im; we will maintain it like everything else. If something specific will be deprecate it we can add a more specific warning at that time.

Changed 4 years ago by chhabraamit

Changed 4 years ago by chhabraamit

comment:3 Changed 4 years ago by chhabraamit

  • Keywords review added

Changed 4 years ago by chhabraamit

comment:4 Changed 4 years ago by exarkun

  • Keywords review removed
  • Owner set to exarkun
  • Status changed from new to assigned

Thanks for working on this ticket, chhabraamit.

The change to __init__.py looks great. I don't see any problems with it. The news file doesn't look quite right though. We don't really have a convention for removing deprecation warnings, since we don't do it very often. However, I think that the right thing to do here is to include a bugfix fragment. Nothing important or useful is being removed here. Instead, a bug - a warning that should not be emitted - is being fixed.

I'll adjust the news fragment and apply the patch. Thanks again!

comment:5 Changed 4 years ago by exarkun

One other point - news fragments go into the project or subproject where the change is being made. This change is made to Twisted Words, so the news fragment belongs in twisted/words/topfiles/.

comment:6 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [34100]) Remove rewrite warning from twisted.words.im package.

Author: chhabraamit Reviewer: exarkun Fixes: #5598

Twisted Words is maintained like any other part of Twisted, with incremental improvements and backwards compatible changes.

Note: See TracTickets for help on using tickets.