Opened 7 years ago

Last modified 7 years ago

#5568 defect new

_cbGetPublicKey method of SSHUserAuthClient heck of swallows exceptions

Reported by: teratorn Owned by:
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch:


This code needs to log the Failure.

Change History (4)

comment:1 Changed 7 years ago by DefaultCC Plugin

Cc: z3p added

comment:2 Changed 7 years ago by Jean-Paul Calderone

Keywords: easy removed
Owner: set to teratorn

All conch tickets are not easy by default. Also, please fix the summary and description of this ticket.

comment:3 Changed 7 years ago by teratorn

The method, if passed in a failure (it's a target of a Deferred.addBoth call), needs to log it before proceeding to fail the authentication request. I don't know how to make the summary more clear - it swallows at exception it (in my opinion) shouldn't. And I don't know how to change ticket descriptions.

Anyone that looks at the method in question would be able to understand exactly that this ticket is about.

But if you actually have some constructive criticism to give, please do so - "fix it" is completely unhelpful.

comment:4 Changed 7 years ago by teratorn

Owner: teratorn deleted
Note: See TracTickets for help on using tickets.