Opened 9 years ago
Closed 8 years ago
#5564 task closed fixed (fixed)
Remove deprecated API in t.names.root
Reported by: | Thijs Triemstra | Owned by: | Tom Prince |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | names | Keywords: | easy |
Cc: | Thijs Triemstra | Branch: |
branches/names-root-5564
branch-diff, diff-cov, branch-cov, buildbot |
Author: | piffey |
Attachments (3)
Change History (16)
Changed 9 years ago by
Attachment: | 5564.patch added |
---|
comment:1 follow-up: 3 Changed 9 years ago by
Keywords: | review added |
---|
comment:2 Changed 9 years ago by
Author: | → thijs |
---|---|
Branch: | → branches/names-root-5564 |
(In [33962]) Branching to 'names-root-5564'
comment:3 Changed 9 years ago by
Author: | thijs → piffey |
---|---|
Keywords: | review removed |
Owner: | set to Piffey |
Replying to piffey:
First time contributing, followed the model of other tickets and hope everything is proper. Added news file already as well.
Thanks. All looks good but the news file wasn't included in the patch. Can you attach it here?
Changed 9 years ago by
Attachment: | 5564.removal added |
---|
Must have forgotten to grab the new file with svn diff. Whoops!
comment:4 follow-up: 6 Changed 9 years ago by
Thanks. The news file doesn't need to mention the removed unit tests, only the removed public APIs. Also, if you can factor out the duplicate text in a way that doesn't make it sound awkward, that'd be great.
To future reviewers, though this looks pretty good and is probably just about in shape to merge to trunk, please do not merge to trunk yet.
comment:5 Changed 9 years ago by
Keywords: | review added |
---|
comment:6 Changed 9 years ago by
Owner: | changed from Piffey to Jean-Paul Calderone |
---|
comment:7 follow-up: 8 Changed 9 years ago by
Keywords: | review removed |
---|
Don't think there's anything left to review here.
comment:8 Changed 8 years ago by
Owner: | changed from Jean-Paul Calderone to Thijs Triemstra |
---|---|
Status: | new → assigned |
comment:9 follow-up: 10 Changed 8 years ago by
Owner: | changed from Thijs Triemstra to Jean-Paul Calderone |
---|---|
Status: | assigned → new |
Please don't. There's no reason to rush to remove deprecated things. We should leave them *as long as possible*.
comment:10 Changed 8 years ago by
Replying to exarkun:
Please don't. There's no reason to rush to remove deprecated things. We should leave them *as long as possible*.
Thanks for the clarification, comment 7 got me confused.
comment:11 Changed 8 years ago by
I'm working on #6044, and so need to change all uses of deferredGenerator
. discoverAuthority
uses it, so this ticket can probably land now.
comment:12 Changed 8 years ago by
Owner: | changed from Jean-Paul Calderone to Tom Prince |
---|
That's reasonable.
comment:13 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
First time contributing, followed the model of other tickets and hope everything is proper. Added news file already as well.