Changes between and of Initial VersionVersion 7Ticket #5549


Ignore:
Timestamp:
03/14/12 12:49:06 (10 years ago)
Author:
Jean-Paul Calderone
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5549

    • Property Keywords review added
    • Property Branch changed from to branches/ifilepath-fixups-5549
  • Ticket #5549 – Description

    initial v7  
    1 A handful of problems were identified with the resolution of #2176 post-merge. Rather than revert it, since #2176 didn't ''break'' anything, let's plunge ahead and do those cleanups.
     1A handful of problems were identified with the resolution of #2176 post-merge. Since lots of people are around right now sprinting on Twisted, let's try to get this fixed (and we can do so with this follow-up ticket, rather than do the usual revert, because these issues won't hurt anyone if they're in trunk for a short while).
     2
     3  1. ZipPath used to have a restat method. It no longer does.
     4  1. sep seems like it could have been named better; separator? segmentDelimiter? sep is just a copy of the os module naming without really thinking about what's going on.
     5  1. ZipPath.getsize is untested
     6  1. Speaking of naming and getsize, why not getSize? isdir and isfile are suspicious too.
     7  1. Was descendent omitted intentionally or accidentally?