Opened 10 years ago

Closed 8 years ago

#5442 defect closed fixed (fixed)

test_openFileDescriptors should pass the environment to the created process

Reported by: therve Owned by: therve
Priority: low Milestone:
Component: core Keywords:
Cc: Branch: branches/test-openfd-env-5442
branch-diff, diff-cov, branch-cov, buildbot
Author: therve

Description

If the test setup uses PYTHONPATH (for example to set the location of zope.interface), test_openFileDescriptors fails because the environment is not forwarded.

Change History (4)

comment:1 Changed 8 years ago by therve

Author: therve
Branch: branches/test-openfd-env-5442

(In [39121]) Branching to 'test-openfd-env-5442'

comment:2 Changed 8 years ago by therve

Keywords: review added

comment:3 Changed 8 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to therve

Does the environment need to be copied? I think that spawnProcess should promise not to mutate its argument.

Otherwise, looks fine. Please merge, with or without a fix for the copying, as you think is appropriate.

comment:4 Changed 8 years ago by therve

Resolution: fixed
Status: newclosed

(In [39566]) Merge test-openfd-env-5442

Author: therve Reviewer: exarkun Fixes: #5442

Pass the environment in test_openFileDescriptors when creating a process to make it work when PYTHONPATH is customized.

Note: See TracTickets for help on using tickets.