Opened 6 years ago

Last modified 5 years ago

#5393 defect new

abortConnection tests fails on Windows

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: high Milestone:
Component: core Keywords:
Cc: Branch: branches/resumeProducingThrows-5393
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description (last modified by Itamar Turner-Trauring)

twisted.internet.test.test_tcp.AbortConnectionTestCase_Win32Reactor.test_resumeProducingThrows fails pretty consistently.

Change History (6)

comment:1 Changed 6 years ago by Itamar Turner-Trauring

Owner: set to Itamar Turner-Trauring

comment:2 Changed 6 years ago by Itamar Turner-Trauring

Also, twisted.internet.test.test_tcp.AbortConnectionTestCase_Win32Reactor.test_resumeProducingThrows is failing pretty consistently. Quite possibly it's the same issue; once #5392 is merged we can investigate further and open another separate ticket if necessary.

comment:3 Changed 5 years ago by Itamar Turner-Trauring

Description: modified (diff)
Summary: abortConnection tests fail when used with startTLS instead of SSLabortConnection tests fails on Windows

I can't reproduce an issue with startTLS, but the Windows issue remains, and I can't be bothered to open a new ticket.

comment:4 Changed 5 years ago by itamarst

Author: itamarst
Branch: branches/resumeProducingThrows-5393

(In [35390]) Branching to 'resumeProducingThrows-5393'

comment:5 Changed 5 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: Itamar Turner-Trauring deleted

comment:6 Changed 5 years ago by therve

Keywords: review removed
Owner: set to Itamar Turner-Trauring

Looking at the current buildbot status, it seems the test hasn't failed for a while, so it's hard to tell if it's a real fix with the buildbot result you're giving. Given that the fix is horrible, please add a huge comment when creating the LoopingCall if you feel it's still needed. Thanks!

Note: See TracTickets for help on using tickets.